From b53a2485a43a59f3a8e45baabac6fc84a53cb3e6 Mon Sep 17 00:00:00 2001 From: Shawn Landden Date: Mon, 23 Mar 2015 03:48:41 -0700 Subject: [PATCH] bootchart: remove duplicated code, prevent creating empty files In Debian and rawhide Fedora, which have CONFIG_SCHEDSTATS=n, bootchart creates empty files in /run/log before printing an error. Stop doing that. Moreover this duplicated part of the code doesn't even have error checking so there is no error avoided by doing this early. Reported-by: tfirg_ on IRC --- src/bootchart/bootchart.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/bootchart/bootchart.c b/src/bootchart/bootchart.c index 99ffb86c8..71dffc9ae 100644 --- a/src/bootchart/bootchart.c +++ b/src/bootchart/bootchart.c @@ -395,15 +395,6 @@ int main(int argc, char *argv[]) { sampledata->sampletime = gettime_ns(); sampledata->counter = samples; - if (!of && (access(arg_output_path, R_OK|W_OK|X_OK) == 0)) { - t = time(NULL); - r = strftime(datestr, sizeof(datestr), "%Y%m%d-%H%M", localtime(&t)); - assert_se(r > 0); - - snprintf(output_file, PATH_MAX, "%s/bootchart-%s.svg", arg_output_path, datestr); - of = fopen(output_file, "we"); - } - if (sysfd < 0) sysfd = open("/sys", O_RDONLY|O_CLOEXEC); -- 2.30.2