From a7b74db6e72f4f19f74eabc81c1ebb4cb8670f06 Mon Sep 17 00:00:00 2001 From: Tom Gundersen Date: Fri, 14 Feb 2014 12:15:26 +0100 Subject: [PATCH] sd-rtnl: link flags - don't allow change = 0 The kernel will happily treat 0x0 as 0xffffffff, but it is for backwards compatibility only, so let's not perpetuate this. --- src/libsystemd/sd-rtnl/rtnl-message.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libsystemd/sd-rtnl/rtnl-message.c b/src/libsystemd/sd-rtnl/rtnl-message.c index c780f7188..226329f31 100644 --- a/src/libsystemd/sd-rtnl/rtnl-message.c +++ b/src/libsystemd/sd-rtnl/rtnl-message.c @@ -119,14 +119,12 @@ int sd_rtnl_message_link_set_flags(sd_rtnl_message *m, unsigned flags, unsigned assert_return(m, -EINVAL); assert_return(m->hdr, -EINVAL); assert_return(rtnl_message_type_is_link(m->hdr->nlmsg_type), -EINVAL); + assert_return(change, -EINVAL); ifi = NLMSG_DATA(m->hdr); ifi->ifi_flags = flags; - if (change) - ifi->ifi_change = change; - else - ifi->ifi_change = 0xffffffff; + ifi->ifi_change = change; return 0; } -- 2.30.2