From 9993ef2e9817b35b1d467707bef12b2a140b62dc Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 27 Jan 2015 23:13:28 +0100 Subject: [PATCH] sysv-generator: use is_symlink() utility call where appropriate --- src/sysv-generator/sysv-generator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 1e4d54888..984beab70 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@ -147,7 +147,6 @@ static int generate_unit_file(SysvStub *s) { _cleanup_free_ char *wants = NULL; _cleanup_free_ char *conflicts = NULL; int r; - struct stat st; before = strv_join(s->before, " "); if (!before) @@ -172,9 +171,9 @@ static int generate_unit_file(SysvStub *s) { /* We might already have a symlink with the same name from a Provides:, * or from backup files like /etc/init.d/foo.bak. Real scripts always win, * so remove an existing link */ - if (lstat(unit, &st) == 0 && S_ISLNK(st.st_mode)) { + if (is_symlink(unit)) { log_warning("Overwriting existing symlink %s with real service", unit); - unlink(unit); + (void) unlink(unit); } f = fopen(unit, "wxe"); -- 2.30.2