From 97137ecce66197dda9e276575f10ff262c76fda7 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 8 Nov 2013 13:54:18 +0100 Subject: [PATCH] install: don't override caller's parameter --- src/shared/install.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 987b36d40..cfd4a5af8 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -1618,6 +1618,7 @@ int unit_file_get_default( STRV_FOREACH(p, paths.unit_path) { _cleanup_free_ char *path = NULL, *tmp = NULL; + char *n; if (isempty(root_dir)) path = strappend(*p, "/default.target"); @@ -1630,13 +1631,14 @@ int unit_file_get_default( r = readlink_malloc(path, &tmp); if (r == -ENOENT) continue; - else if (r < 0) + if (r < 0) return r; - *name = strdup(path_get_file_name(tmp)); - if (!*name) + n = strdup(path_get_file_name(tmp)); + if (!n) return -ENOMEM; + *name = n; return 0; } -- 2.30.2