From 8e6d9397b550f5617fc9231e3a275348cda23c89 Mon Sep 17 00:00:00 2001 From: George McCollister Date: Thu, 1 Aug 2013 12:40:01 -0500 Subject: [PATCH 1/1] journal: fix hashmap leak in mmap-cache hashmap_free() wasn't being called on m->contexts and m->fds resulting in a leak. To reproduce do: while(1) { sd_journal_open(&j, SD_JOURNAL_LOCAL_ONLY); sd_journal_close(j); } Memory usage will increase until OOM. --- src/journal/mmap-cache.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/journal/mmap-cache.c b/src/journal/mmap-cache.c index 767f55552..03b57beb0 100644 --- a/src/journal/mmap-cache.c +++ b/src/journal/mmap-cache.c @@ -307,9 +307,13 @@ static void mmap_cache_free(MMapCache *m) { while ((c = hashmap_first(m->contexts))) context_free(c); + hashmap_free(m->contexts); + while ((f = hashmap_first(m->fds))) fd_free(f); + hashmap_free(m->fds); + while (m->unused) window_free(m->unused); -- 2.30.2