From 824a1d590a0ec4d83baa51264a9913a702793230 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Sun, 14 Nov 2010 21:59:25 +0100 Subject: [PATCH 1/1] pam: rename 'no-session' to 'user' cgroup --- man/pam_systemd.xml | 6 +++--- src/pam-module.c | 18 +++++++++--------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/man/pam_systemd.xml b/man/pam_systemd.xml index bfcc68452..3dc371473 100644 --- a/man/pam_systemd.xml +++ b/man/pam_systemd.xml @@ -92,7 +92,7 @@ If is set, a new control group - /user/$USER/no-session + /user/$USER/user is created and the login process moved into it. @@ -115,7 +115,7 @@ remaining processes in the /user/$USER/$XDG_SESSION_ID control group are migrated to - /user/$USER/no-session and + /user/$USER/user and the original control group is removed. @@ -123,7 +123,7 @@ is specified, and no other user session control group remains, except - /user/$USER/no-session, + /user/$USER/user, all remaining processes in the /user/$USER hierarchy are killed and the control group is removed. diff --git a/src/pam-module.c b/src/pam-module.c index 387b77ed5..5f2df4b43 100644 --- a/src/pam-module.c +++ b/src/pam-module.c @@ -335,7 +335,7 @@ _public_ PAM_EXTERN int pam_sm_open_session( r = asprintf(&buf, "/user/%s/%s", username, id); } else - r = asprintf(&buf, "/user/%s/no-session", username); + r = asprintf(&buf, "/user/%s/user", username); if (r < 0) { r = PAM_BUF_ERR; @@ -369,7 +369,7 @@ static int session_remains(pam_handle_t *handle, const char *user_path) { while ((r = cg_read_subgroup(d, &subgroup)) > 0) { - remains = !streq(subgroup, "no-session"); + remains = !streq(subgroup, "user"); free(subgroup); if (remains) @@ -416,7 +416,7 @@ _public_ PAM_EXTERN int pam_sm_close_session( goto finish; } - /* We are probably still in some session/no-session dir. Move ourselves out of the way as first step */ + /* We are probably still in some session/user dir. Move ourselves out of the way as first step */ if ((r = cg_attach(SYSTEMD_CGROUP_CONTROLLER, "/user", 0)) < 0) pam_syslog(handle, LOG_ERR, "Failed to move us away: %s", strerror(-r)); @@ -430,7 +430,7 @@ _public_ PAM_EXTERN int pam_sm_close_session( if ((id = pam_getenv(handle, "XDG_SESSION_ID")) && created) { if (asprintf(&session_path, "/user/%s/%s", username, id) < 0 || - asprintf(&nosession_path, "/user/%s/no-session", username) < 0) { + asprintf(&nosession_path, "/user/%s/user", username) < 0) { r = PAM_BUF_ERR; goto finish; } @@ -444,10 +444,10 @@ _public_ PAM_EXTERN int pam_sm_close_session( } else { pam_syslog(handle, LOG_INFO, "Moving remaining processes of user session %s of %s into control group %s.", id, username, nosession_path); - /* Migrate processes from session to - * no-session cgroup. First, try to create the - * no-session group in case it doesn't exist - * yet. Also, delete the session group. */ + /* Migrate processes from session to user + * cgroup. First, try to create the user group + * in case it doesn't exist yet. Also, delete + * the session group. */ create_user_group(handle, nosession_path, pw, false, false); if ((r = cg_migrate_recursive(SYSTEMD_CGROUP_CONTROLLER, session_path, nosession_path, false, true)) < 0) @@ -464,7 +464,7 @@ _public_ PAM_EXTERN int pam_sm_close_session( /* Kill user processes not attached to any session */ if (kill_user && r == 0) { - /* Kill no-session cgroup */ + /* Kill user cgroup */ if ((r = cg_kill_recursive_and_wait(SYSTEMD_CGROUP_CONTROLLER, user_path, true)) < 0) pam_syslog(handle, LOG_ERR, "Failed to kill user cgroup: %s", strerror(-r)); } else { -- 2.30.2