From 79102489260da9f577d7c1fb3665dd95d1596bea Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Tue, 7 Mar 2006 23:20:10 +0100 Subject: [PATCH] warn about %e, MODALIAS, $modalias --- udev_rules.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/udev_rules.c b/udev_rules.c index 9fa2253e9..1aedb1111 100644 --- a/udev_rules.c +++ b/udev_rules.c @@ -290,6 +290,12 @@ static int find_free_number(const char *base, const char *devpath) char filename[PATH_SIZE]; struct udevice *udev_db; int num = 0; + static int warn = 1; + + if (warn) { + err("%%e is deprecated, will be removed and is unlikey to work correctly. Don't use it."); + warn = 0; + } /* check if the device already owns a matching name */ udev_db = udev_device_init(); @@ -616,6 +622,13 @@ found: case SUBST_MODALIAS: { const char *value; + static int warn = 1; + + if (warn) { + err("$modalias is deprecated, use $env{MODALIAS} or " + "$sysfs{modalias} instead."); + warn = 0; + } value = sysfs_attr_get_value(udev->dev->devpath, "modalias"); if (value != NULL) { @@ -715,6 +728,12 @@ static int match_rule(struct udevice *udev, struct udev_rule *rule) if (rule->modalias.operation != KEY_OP_UNSET) { const char *value; + static int warn = 1; + + if (warn) { + err("MODALIAS is deprecated, use ENV{MODALIAS} or SYSFS{modalias} instead."); + warn = 0; + } value = sysfs_attr_get_value(udev->dev->devpath, "modalias"); if (value == NULL) { -- 2.30.2