From 7849c2acd479278d54851694762b967610912d02 Mon Sep 17 00:00:00 2001 From: Thomas Hindoe Paaboel Andersen Date: Fri, 27 Jun 2014 00:07:39 +0200 Subject: [PATCH] coredump: make sure variable is set if uncompressed reorder the code so the fstat is done before we can jump to uncompressed --- src/journal/coredump.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/journal/coredump.c b/src/journal/coredump.c index 5e93091f8..ab8fd2cf0 100644 --- a/src/journal/coredump.c +++ b/src/journal/coredump.c @@ -345,16 +345,16 @@ static int save_external_coredump(const char *info[_INFO_LEN], goto fail; } - if (lseek(fd, 0, SEEK_SET) == (off_t) -1) { - log_error("Failed to seek on %s: %m", tmp); - goto uncompressed; - } - if (fstat(fd, &st) < 0) { log_error("Failed to fstat coredump %s: %m", tmp); goto fail; } + if (lseek(fd, 0, SEEK_SET) == (off_t) -1) { + log_error("Failed to seek on %s: %m", tmp); + goto uncompressed; + } + #ifdef HAVE_XZ /* If we will remove the coredump anyway, do not compress. */ if (maybe_remove_external_coredump(NULL, st.st_size) == 0 -- 2.30.2