From 70b64bd3561c2bbe6cad2e590d4e3e25426f75b5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 27 Jan 2014 01:23:16 -0500 Subject: [PATCH] core: simplify check for path absoluteness Just a microopt. --- src/core/unit.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/core/unit.c b/src/core/unit.c index e3b620603..fc1465834 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -2997,17 +2997,15 @@ int unit_require_mounts_for(Unit *u, const char *path) { * units can easily determine which units to make themselves a * dependency of. */ + if (!path_is_absolute(path)) + return -EINVAL; + p = strdup(path); if (!p) return -ENOMEM; path_kill_slashes(p); - if (!path_is_absolute(p)) { - free(p); - return -EINVAL; - } - if (!path_is_safe(p)) { free(p); return -EPERM; -- 2.30.2