From 608d41f355d580a6f73e76b298bfc1b4e3155b80 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 25 Mar 2013 23:49:13 +0100 Subject: [PATCH] cryptsetup-generator: add a missing OOM check --- src/cryptsetup/cryptsetup-generator.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c index 0a51db893..5c4a2807a 100644 --- a/src/cryptsetup/cryptsetup-generator.c +++ b/src/cryptsetup/cryptsetup-generator.c @@ -169,8 +169,6 @@ static int create_disk( } free(to); - to = NULL; - if (!nofail) to = strjoin(arg_dest, "/cryptsetup.target.requires/", n, NULL); else @@ -183,12 +181,13 @@ static int create_disk( log_error("Failed to create symlink '%s' to '%s': %m", from, to); return -errno; } - - free(to); - to = NULL; } e = unit_name_escape(name); + if (!e) + return log_oom(); + + free(to); to = strjoin(arg_dest, "/dev-mapper-", e, ".device.requires/", n, NULL); if (!to) return log_oom(); -- 2.30.2