From 576a13eaf6491fdbebc817ef613963ac24cfb6b8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 3 Mar 2015 00:02:31 -0500 Subject: [PATCH] fsck: remove unnecessary check gcc was complaining that progress_rc might be used uninitalized. But it was actually always set, because the condition was always satisfied. Remove the condition. --- src/fsck/fsck.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/fsck/fsck.c b/src/fsck/fsck.c index cf4d37571..a4a15da1b 100644 --- a/src/fsck/fsck.c +++ b/src/fsck/fsck.c @@ -316,10 +316,8 @@ int main(int argc, char *argv[]) { if (arg_force) cmdline[i++] = "-f"; - if (progress_pipe[1] >= 0) { - xsprintf(dash_c, "-C%i", progress_pipe[1]); - cmdline[i++] = dash_c; - } + xsprintf(dash_c, "-C%i", progress_pipe[1]); + cmdline[i++] = dash_c; cmdline[i++] = device; cmdline[i++] = NULL; @@ -330,18 +328,15 @@ int main(int argc, char *argv[]) { goto finish; } else if (pid == 0) { /* Child */ - if (progress_pipe[0] >= 0) - safe_close(progress_pipe[0]); + safe_close(progress_pipe[0]); execv(cmdline[0], (char**) cmdline); _exit(8); /* Operational error */ } progress_pipe[1] = safe_close(progress_pipe[1]); - if (progress_pipe[0] >= 0) { - progress_rc = process_progress(progress_pipe[0], pid, st.st_rdev); - progress_pipe[0] = -1; - } + progress_rc = process_progress(progress_pipe[0], pid, st.st_rdev); + progress_pipe[0] = -1; q = wait_for_terminate(pid, &status); if (q < 0) { -- 2.30.2