From 5483a18693871e67cff6d85e43ca843cd976d019 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Wed, 3 Apr 2013 16:32:01 -0400 Subject: [PATCH 1/1] efivars: un-leak a few strings --- src/shared/efivars.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/shared/efivars.c b/src/shared/efivars.c index 06cf127de..8d004bad3 100644 --- a/src/shared/efivars.c +++ b/src/shared/efivars.c @@ -231,10 +231,12 @@ int efi_get_boot_option( if (title_size > l - offsetof(struct boot_option, title)) return -EINVAL; - s = utf16_to_utf8(header->title, title_size); - if (!s) { - err = -ENOMEM; - goto err; + if (title) { + s = utf16_to_utf8(header->title, title_size); + if (!s) { + err = -ENOMEM; + goto err; + } } if (header->path_len > 0) { @@ -270,12 +272,13 @@ int efi_get_boot_option( if (dpath->drive.signature_type != 0x02) continue; - efi_guid_to_id128(dpath->drive.signature, &p_uuid); + if (part_uuid) + efi_guid_to_id128(dpath->drive.signature, &p_uuid); continue; } /* Sub-Type 4 – File Path */ - if (dpath->sub_type == 0x04) { + if (dpath->sub_type == 0x04 && !p && path) { p = utf16_to_utf8(dpath->path, dpath->length-4); continue; } -- 2.30.2