From 4e67ddd6b39c2847cc399ab0874427baa7ea8935 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Sat, 10 Jul 2010 02:41:06 +0200 Subject: [PATCH] units: introduce umount.target for unmounting all file systems --- Makefile.am | 1 + fixme | 2 -- src/automount.c | 5 +++++ src/mount.c | 4 ++++ src/special.h | 1 + units/umount.target | 12 ++++++++++++ 6 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 units/umount.target diff --git a/Makefile.am b/Makefile.am index f6ae7d62c..57b8aa525 100644 --- a/Makefile.am +++ b/Makefile.am @@ -126,6 +126,7 @@ dist_systemunit_DATA = \ units/rpcbind.target \ units/rtc-set.target \ units/shutdown.target \ + units/umount.target \ units/sigpwr.target \ units/sockets.target \ units/swap.target \ diff --git a/fixme b/fixme index cd5a23f98..3b3d0f7c8 100644 --- a/fixme +++ b/fixme @@ -35,8 +35,6 @@ * selinux -* introduce umount.target - * pull in umount.target and shutdown.target from emergency.service (?) * Show exit status auf auxiliary programs in systemctl status diff --git a/src/automount.c b/src/automount.c index 39eb3dd01..b5003b3a7 100644 --- a/src/automount.c +++ b/src/automount.c @@ -36,6 +36,7 @@ #include "unit-name.h" #include "dbus-automount.h" #include "bus-errors.h" +#include "special.h" static const UnitActiveState state_translation_table[_AUTOMOUNT_STATE_MAX] = { [AUTOMOUNT_DEAD] = UNIT_INACTIVE, @@ -194,6 +195,10 @@ static int automount_load(Unit *u) { if ((r = unit_add_dependency(u, UNIT_BEFORE, UNIT(a->mount), true)) < 0) return r; + + if (a->meta.default_dependencies) + if ((r = unit_add_two_dependencies_by_name(UNIT(a), UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_UMOUNT_TARGET, NULL, true)) < 0) + return r; } return automount_verify(a); diff --git a/src/mount.c b/src/mount.c index 498732eef..57c258f9f 100644 --- a/src/mount.c +++ b/src/mount.c @@ -367,6 +367,10 @@ static int mount_load(Unit *u) { if ((r = unit_add_default_cgroup(u)) < 0) return r; + + if (m->meta.default_dependencies && !path_equal(m->where, "/")) + if ((r = unit_add_two_dependencies_by_name(UNIT(m), UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_UMOUNT_TARGET, NULL, true)) < 0) + return r; } return mount_verify(m); diff --git a/src/special.h b/src/special.h index 9ddabde3a..5ecdd3ccf 100644 --- a/src/special.h +++ b/src/special.h @@ -29,6 +29,7 @@ * it to bring all services down that want to be brought down on * system shutdown. */ #define SPECIAL_SHUTDOWN_TARGET "shutdown.target" +#define SPECIAL_UMOUNT_TARGET "umount.target" #define SPECIAL_LOGGER_SOCKET "systemd-logger.socket" diff --git a/units/umount.target b/units/umount.target new file mode 100644 index 000000000..a5f31e04c --- /dev/null +++ b/units/umount.target @@ -0,0 +1,12 @@ +# This file is part of systemd. +# +# systemd is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. + +# See systemd.special(7) for details + +[Unit] +Description=Unmount All Filesystems +OnlyByDependency=yes -- 2.30.2