From 4e0296a943e85316ecce0324248f9543887b8a9a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 15 Jul 2014 22:47:03 -0400 Subject: [PATCH] resolve: avoid use of uninitalized variable --- src/resolve/resolved-dns-packet.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/resolve/resolved-dns-packet.c b/src/resolve/resolved-dns-packet.c index 2a666924b..a503b0150 100644 --- a/src/resolve/resolved-dns-packet.c +++ b/src/resolve/resolved-dns-packet.c @@ -594,7 +594,7 @@ fail: } int dns_packet_read_rr(DnsPacket *p, DnsResourceRecord **ret, size_t *start) { - _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr; size_t saved_rindex, offset; uint16_t rdlength; const void *d; @@ -603,11 +603,11 @@ int dns_packet_read_rr(DnsPacket *p, DnsResourceRecord **ret, size_t *start) { assert(p); assert(ret); - saved_rindex = p->rindex; - rr = dns_resource_record_new(); if (!rr) - goto fail; + return -ENOMEM; + + saved_rindex = p->rindex; r = dns_packet_read_key(p, &rr->key, NULL); if (r < 0) -- 2.30.2