From 40672b99c7da7efd317fc31612504fe7d5ab0b65 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 28 Jan 2015 17:48:05 +0100 Subject: [PATCH] util: add comment explaining hostname_is_valid() --- src/shared/util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/shared/util.c b/src/shared/util.c index 891182a35..11cab6dcf 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -4248,6 +4248,11 @@ bool hostname_is_valid(const char *s) { if (isempty(s)) return false; + /* Doesn't accept empty hostnames, hostnames with trailing or + * leading dots, and hostnames with multiple dots in a + * sequence. Also ensures that the length stays below + * HOST_NAME_MAX. */ + for (p = s, dot = true; *p; p++) { if (*p == '.') { if (dot) -- 2.30.2