From 3b97fcbd28f92a1e51887fef5de8844a89bde523 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 3 Feb 2015 18:17:00 +0100 Subject: [PATCH 1/1] journald: fix some xsprrintf() buffer size fallout --- src/journal/journald-kmsg.c | 2 +- src/journal/journald-syslog.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c index 0b02eff6e..c4216c404 100644 --- a/src/journal/journald-kmsg.c +++ b/src/journal/journald-kmsg.c @@ -40,7 +40,7 @@ void server_forward_kmsg( const struct ucred *ucred) { struct iovec iovec[5]; - char header_priority[4], + char header_priority[DECIMAL_STR_MAX(priority) + 3], header_pid[sizeof("[]: ")-1 + DECIMAL_STR_MAX(pid_t) + 1]; int n = 0; char *ident_buf = NULL; diff --git a/src/journal/journald-syslog.c b/src/journal/journald-syslog.c index 355f6e6a4..7d545ca31 100644 --- a/src/journal/journald-syslog.c +++ b/src/journal/journald-syslog.c @@ -124,7 +124,7 @@ static void forward_syslog_raw(Server *s, int priority, const char *buffer, cons void server_forward_syslog(Server *s, int priority, const char *identifier, const char *message, const struct ucred *ucred, const struct timeval *tv) { struct iovec iovec[5]; - char header_priority[4], header_time[64], + char header_priority[DECIMAL_STR_MAX(priority) + 3], header_time[64], header_pid[sizeof("[]: ")-1 + DECIMAL_STR_MAX(pid_t) + 1]; int n = 0; time_t t; -- 2.30.2