From 2c455af4c765463c75df79acba34d2347c03cbff Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 20 Jun 2014 00:20:35 +0200 Subject: [PATCH] copy: don't eat up error from chown()/chmod() The idea was to not fail on, nor to ignore errors from chown()/chmod(), but to proceed and simply return the most recent error... --- src/shared/copy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/copy.c b/src/shared/copy.c index 867e49bf8..7c3fab690 100644 --- a/src/shared/copy.c +++ b/src/shared/copy.c @@ -179,6 +179,8 @@ static int fd_copy_directory(int df, const char *from, const struct stat *st, in if (fdt < 0) return -errno; + r = 0; + if (created) { if (fchown(fdt, st->st_uid, st->st_gid) < 0) r = -errno; @@ -187,7 +189,6 @@ static int fd_copy_directory(int df, const char *from, const struct stat *st, in r = -errno; } - r = 0; FOREACH_DIRENT(de, d, return -errno) { struct stat buf; int q; -- 2.30.2