From 297d563de43167f21510061d2de55979a4d65ac4 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 27 Jan 2015 01:47:37 +0100 Subject: [PATCH] core: explain why failing to set up the crash handler is not a real problem http://lists.freedesktop.org/archives/systemd-devel/2015-January/027428.html --- src/core/main.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/core/main.c b/src/core/main.c index e2e139956..ce37c59e8 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -224,12 +224,17 @@ noreturn static void crash(int sig) { } static void install_crash_handler(void) { - struct sigaction sa = { + static const struct sigaction sa = { .sa_handler = crash, - .sa_flags = SA_NODEFER, + .sa_flags = SA_NODEFER, /* So that we can raise the signal again from the signal handler */ }; + int r; - sigaction_many(&sa, SIGNALS_CRASH_HANDLER, -1); + /* We ignore the return value here, since, we don't mind if we + * cannot set up a crash handler */ + r = sigaction_many(&sa, SIGNALS_CRASH_HANDLER, -1); + if (r < 0) + log_debug_errno(r, "I had trouble setting up the crash handler, ignoring: %m"); } static int console_setup(void) { -- 2.30.2