From 1f4ffab4a84a9fb4c7b10c01a2435f79c39ef05e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sat, 8 Jul 2017 18:04:44 -0400 Subject: [PATCH] sd-login: fix memleak when output argument is NULL --- src/libelogind/sd-login/sd-login.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libelogind/sd-login/sd-login.c b/src/libelogind/sd-login/sd-login.c index 5f90ba70c..80b8f8fef 100644 --- a/src/libelogind/sd-login/sd-login.c +++ b/src/libelogind/sd-login/sd-login.c @@ -942,7 +942,8 @@ _public_ int sd_get_uids(uid_t **users) { } _public_ int sd_get_machine_names(char ***machines) { - char **l, **a, **b; + _cleanup_strv_free_ char **l = NULL; + char **a, **b; int r; r = get_files_in_directory("/run/systemd/machines/", &l); @@ -971,8 +972,10 @@ _public_ int sd_get_machine_names(char ***machines) { *b = NULL; } - if (machines) + if (machines) { *machines = l; + l = NULL; + } return r; } -- 2.30.2