From 1b2457e16dbbaa5e587c5e36d274a48c585d4840 Mon Sep 17 00:00:00 2001 From: Lukas Nykryn Date: Wed, 15 Jan 2014 12:46:44 +0100 Subject: [PATCH] Revert "Revert "coredumpctl: in case of error free pattern after print"" In the case of the error set_consume will free the pointer 'pattern' which is later used in log_error. Either we should stop priniting that or use simple set_put and free pattern manually. This reverts commit ece6b8fd5bbc1fee16f652e680e3033f2f3efc4a. --- src/journal/coredumpctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index 70eaf0e64..e564ab656 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -126,10 +126,11 @@ static int add_match(Set *set, const char *match) { goto fail; log_debug("Adding pattern: %s", pattern); - r = set_consume(set, pattern); + r = set_put(set, pattern); if (r < 0) { log_error("Failed to add pattern '%s': %s", pattern, strerror(-r)); + free(pattern); goto fail; } -- 2.30.2