From 0591220f339c313761f9a208e88fb719db566993 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 29 Jan 2013 10:32:39 -0500 Subject: [PATCH] core: fix %U when no User= used When the username was not explicitly specified, both %U and %u would print the username. Make %U always print UID. --- src/core/unit-printf.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/core/unit-printf.c b/src/core/unit-printf.c index 3aa735e5b..7430beb3d 100644 --- a/src/core/unit-printf.c +++ b/src/core/unit-printf.c @@ -26,6 +26,7 @@ #include "strv.h" #include "unit-name.h" #include "unit-printf.h" +#include "macro.h" static char *specifier_prefix_and_instance(char specifier, void *data, void *userdata) { Unit *u = userdata; @@ -123,6 +124,7 @@ static char *specifier_user_name(char specifier, void *data, void *userdata) { ExecContext *c; int r; const char *username; + char _cleanup_free_ *tmp = NULL; uid_t uid; char *printed = NULL; @@ -130,12 +132,13 @@ static char *specifier_user_name(char specifier, void *data, void *userdata) { c = unit_get_exec_context(u); - /* get USER env from our own env if set */ - if (!c || !c->user) - return getusername_malloc(); + if (c && c->user) + username = c->user; + else + /* get USER env from env or our own uid */ + username = tmp = getusername_malloc(); /* fish username from passwd */ - username = c->user; r = get_user_creds(&username, &uid, NULL, NULL, NULL); if (r < 0) return NULL; -- 2.30.2