chiark / gitweb /
fixed statfs.f_type signed vs unsigned comparisons
authorHarald Hoyer <harald@redhat.com>
Wed, 17 Apr 2013 16:03:39 +0000 (18:03 +0200)
committerHarald Hoyer <harald@redhat.com>
Wed, 17 Apr 2013 16:14:25 +0000 (18:14 +0200)
commit8c68a70170b31f93c287f29fd06c6c17edaf19ad
tree0cde44b88db55795d242dde12d9e5c725d173486
parent90cf049bfe9a7dcb20a1bd0d12e8b2194dbcd357
fixed statfs.f_type signed vs unsigned comparisons

statfs.f_type is signed but the filesystem magics are unsigned.
Casting the magics to signed will not make the signed.

Problem seen on big-endian 64bit s390x with __fsword_t 8 bytes.

Casting statfs.f_type to unsigned on the other hand will get us what we
need.

https://bugzilla.redhat.com/show_bug.cgi?id=953217
src/journal/sd-journal.c
src/readahead/readahead-collect.c
src/shared/util.c