chiark / gitweb /
elogind.git
5 years agoman: mark hwdb related man pages as conditional
Michael Biebl [Thu, 25 Dec 2014 23:04:19 +0000 (00:04 +0100)]
man: mark hwdb related man pages as conditional

Follow-up fix for commit fe659612e40e6a0cf91a73b10aa45eea958b747e.

5 years agoman: typo in sd_watchdog_enabled notes
Manuel Mendez [Thu, 25 Dec 2014 16:59:08 +0000 (11:59 -0500)]
man: typo in sd_watchdog_enabled notes

https://bugs.freedesktop.org/show_bug.cgi?id=87642

5 years agotest: wait for cloned thread to exit
Filipe Brandenburger [Thu, 25 Dec 2014 16:40:46 +0000 (11:40 -0500)]
test: wait for cloned thread to exit

In test_raw_clone, make sure the cloned thread calls _exit() and in the parent
thread call waitpid(..., __WCLONE) to wait for the child thread to terminate,
otherwise there is a race condition where the child thread will log to the
console after the test process has already exited and the assertion from the
child thread might not be enforced.

The absence of this patch might also create problems for other tests that would
be added after this one, since potentially both parent and child would run
those tests as the child would continue running.

Tested by confirming that the logs from the child are printed before the test
terminates and that a false assertion in the child aborts the test with a core
dump.

[zj: also add check for the return value.]

5 years agotest: only use assert_se in test_raw_clone
Filipe Brandenburger [Tue, 23 Dec 2014 18:14:46 +0000 (10:14 -0800)]
test: only use assert_se in test_raw_clone

The asserts used in the tests should never be allowed to be optimized away.

5 years agoconfigure.ac: keep posix compat for string tests
Dave Reisner [Thu, 25 Dec 2014 16:41:06 +0000 (11:41 -0500)]
configure.ac: keep posix compat for string tests

'==' and '=' are equivalent in /bin/bash, but POSIX compliant shells do
not understand '==.'

5 years agoman: add a note why %U,%h,%s are mostly useless
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 16:12:54 +0000 (11:12 -0500)]
man: add a note why %U,%h,%s are mostly useless

The reasons were already given in the description of %U, but the
are easy to overlook, and it's better to be explicit to avoid
confusion.

5 years agorun: uninitialized variable
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:52:38 +0000 (10:52 -0500)]
run: uninitialized variable

5 years agoata_id: remove temp variable to kill warning
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:44:34 +0000 (10:44 -0500)]
ata_id: remove temp variable to kill warning

src/udev/ata_id/ata_id.c:503:24: warning: assignment from incompatible pointer type
         identify_words = &identify.wyde;
                        ^

5 years agoata_id: modernize
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:42:23 +0000 (10:42 -0500)]
ata_id: modernize

5 years agopam_systemd: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:48 +0000 (10:38 -0800)]
pam_systemd: remove spurious include of <sys/capability.h>

It does not use any functions or constants from libcap directly.

Tested that "pam_systemd.la" builds cleanly and works after this change.

5 years agotimedated: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:47 +0000 (10:38 -0800)]
timedated: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_SYS_TIME constant
in use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-timedated" builds cleanly and works after this change.

5 years agolocaled: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:46 +0000 (10:38 -0800)]
localed: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-localed" builds cleanly and works after this change.

5 years agobus: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:50 +0000 (10:38 -0800)]
bus: remove spurious include of <sys/capability.h>

They do not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by bus-objects.c comes from <linux/capability.h> imported through
"missing.h". The "missing.h" header is imported through "util.h" which gets
imported in "bus-util.h".

Tested that everything builds cleanly after this change.

5 years agomachined: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:49 +0000 (10:38 -0800)]
machined: remove spurious include of <sys/capability.h>

They do not use any functions from libcap directly. The CAP_KILL constant in
use by these files comes from <linux/capability.h> imported through
"missing.h".

Tested that "systemd-machined" builds cleanly and works after this change.

5 years agohostnamed: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:45 +0000 (10:38 -0800)]
hostnamed: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-hostnamed" builds cleanly and works after this change.

5 years agotmpfiles: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:44 +0000 (10:38 -0800)]
tmpfiles: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_MKNOD constant in
use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-tmpfiles" builds cleanly and works after this change.

5 years agologind: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:43 +0000 (10:38 -0800)]
logind: remove spurious include of <sys/capability.h>

They do not use any functions from libcap directly. The CAP_* constants in use
through these files come from "missing.h" which will import <linux/capability.h>
and complement it with CAP_* constants not defined by the current kernel
headers. The "missing.h" header is imported through "util.h" which gets
imported in "logind.h".

Tested that "systemd-logind" builds cleanly and works after this change.

5 years agonspawn: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:42 +0000 (10:38 -0800)]
nspawn: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_* constants in use
through this file come from "missing.h" which will import <linux/capability.h>
and complement it with CAP_* constants not defined by the current kernel
headers.

Add an explicit import of our "capability.h" since it does use the function
capability_bounding_set_drop from that header file. Previously, that header was
implicitly imported through through "cap-list.h".

Tested that "systemd-nspawn" builds cleanly and works after this change.

5 years agodoc: os-release: mention all shell characters that must be escaped
Mantas Mikulėnas [Wed, 24 Dec 2014 12:46:20 +0000 (14:46 +0200)]
doc: os-release: mention all shell characters that must be escaped

Since the manpage already talks about shell-compatibility, it should be
more accurate about what needs to be escaped and how.

5 years agobuild-sys: remove references to dbusinterfacedir
Filipe Brandenburger [Tue, 23 Dec 2014 18:59:15 +0000 (10:59 -0800)]
build-sys: remove references to dbusinterfacedir

This directory is not used by systemd.

Tested by running a full build, running `make install` and comparing the file
list in the target trees and making sure that `make distcheck` still works.

5 years agobuild-sys: do not use pkgconfig dbus-1.pc to find dbus directories
Filipe Brandenburger [Tue, 23 Dec 2014 18:59:14 +0000 (10:59 -0800)]
build-sys: do not use pkgconfig dbus-1.pc to find dbus directories

Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use
directories relative to ${sysconfdir} and ${datadir} instead.

This approach was suggested by Simon McVittie in:
http://lists.freedesktop.org/archives/systemd-devel/2014-October/024388.html

Tested by building and installing systemd without the dbus-devel installed.
Without this patch, the dbus files and directories end up in the root of the
filesystem. With this patch, they end up in the same locations as previously
(assuming default ${sysconfdir} and ${datadir}) whether dbus-devel is present
or not. Also made sure that `make check` works without dbus-devel installed.

5 years agotimesync: remove square(), use pow instead
Cristian Rodríguez [Tue, 23 Dec 2014 20:52:51 +0000 (17:52 -0300)]
timesync: remove square(), use pow instead

In any case, the compiler generates the same code inline and never
actually calls the library function.

5 years agotest: do not use last cap from kernel in test-cap-list
Filipe Brandenburger [Tue, 23 Dec 2014 21:51:40 +0000 (13:51 -0800)]
test: do not use last cap from kernel in test-cap-list

The new test-cap-list introduced in commit 2822da4fb7f891 uses the included
table of capabilities. However, it uses cap_last_cap() which probes the kernel
for the last available capability. On an older kernel (e.g. 3.10 from RHEL 7)
that causes the test to fail with the following message:

    Assertion '!capability_to_name(cap_last_cap()+1)' failed at src/test/test-cap-list.c:30, function main(). Aborting.

Fix it by exporting the size of the static table and using it in the test
instead of the dynamic one from the current kernel.

Tested by successfully running ./test-cap-list and the whole `make check` test
suite with this patch on a RHEL 7 host.

5 years agoudev: fix another strict aliasing issue
Shawn Paul Landden [Tue, 23 Dec 2014 23:04:37 +0000 (15:04 -0800)]
udev: fix another strict aliasing issue

5 years agolibudev: fix strict aliasing violation
Shawn Paul Landden [Tue, 23 Dec 2014 23:04:36 +0000 (15:04 -0800)]
libudev: fix strict aliasing violation

5 years agobuild-sys: update path in reference to sd-lldp.h
Filipe Brandenburger [Tue, 23 Dec 2014 23:03:21 +0000 (15:03 -0800)]
build-sys: update path in reference to sd-lldp.h

The file was moved from src/libsystemd-network to src/systemd in commit
7a6f1457462840 ("sd-lldp: minor header cleanup").

This fixes "make distcheck".

5 years agomachined: add org.freedesktop.machine1.policy.in to POTFILES.in
Filipe Brandenburger [Tue, 23 Dec 2014 23:02:14 +0000 (15:02 -0800)]
machined: add org.freedesktop.machine1.policy.in to POTFILES.in

The new polkit file was introduced in commit d04c1fb8e21560 ("machined:
introduce polkit for OpenLogin() call").

5 years agoupdate TODO
Lennart Poettering [Thu, 25 Dec 2014 02:20:20 +0000 (03:20 +0100)]
update TODO

5 years agomachined: beef up machined image listing with creation/modification times of subvolumes
Lennart Poettering [Thu, 25 Dec 2014 02:19:19 +0000 (03:19 +0100)]
machined: beef up machined image listing with creation/modification times of subvolumes

We make use of the btrfs subvol crtime for this, and for gpt images of a
manually managed xattr, if we can.

5 years agoimport: prefer usec_t over time_t
Lennart Poettering [Thu, 25 Dec 2014 02:14:09 +0000 (03:14 +0100)]
import: prefer usec_t over time_t

5 years agoupdate TODO
Lennart Poettering [Wed, 24 Dec 2014 15:55:03 +0000 (16:55 +0100)]
update TODO

5 years agoupdate TODO
Lennart Poettering [Wed, 24 Dec 2014 15:52:20 +0000 (16:52 +0100)]
update TODO

5 years agoimport: add a new "pull-gpt" verb for downloading GPT disk images from the internet
Lennart Poettering [Wed, 24 Dec 2014 15:44:56 +0000 (16:44 +0100)]
import: add a new "pull-gpt" verb for downloading GPT disk images from the internet

5 years agoimport: three minor fixes
Lennart Poettering [Wed, 24 Dec 2014 15:43:46 +0000 (16:43 +0100)]
import: three minor fixes

5 years agoimport: print friendly error messages on errors
Lennart Poettering [Wed, 24 Dec 2014 15:43:20 +0000 (16:43 +0100)]
import: print friendly error messages on errors

5 years agoimport: remember when we were finished importing
Lennart Poettering [Wed, 24 Dec 2014 15:42:41 +0000 (16:42 +0100)]
import: remember when we were finished importing

5 years agoimport: make the dkr import URL a part of the import object, not the import name...
Lennart Poettering [Wed, 24 Dec 2014 15:41:51 +0000 (16:41 +0100)]
import: make the dkr import URL a part of the import object, not the import name object

5 years agomachined: fix writability check for GPT images
Lennart Poettering [Wed, 24 Dec 2014 15:40:30 +0000 (16:40 +0100)]
machined: fix writability check for GPT images

5 years agoutil: make creation time xattr logic more generic
Lennart Poettering [Wed, 24 Dec 2014 15:39:55 +0000 (16:39 +0100)]
util: make creation time xattr logic more generic

5 years agosd-bus: rename sd_bus_open_system_container() to sd_bus_open_system_machine()
Lennart Poettering [Tue, 23 Dec 2014 22:38:13 +0000 (23:38 +0100)]
sd-bus: rename sd_bus_open_system_container() to sd_bus_open_system_machine()

Pretty much everywhere else we use the generic term "machine" when
referring to containers in API, so let's do though in sd-bus too. In
particular, since the concept of a "container" exists in sd-bus too, but
as part of the marshalling system.

5 years agoutil: fix strict aliasing violations in use of struct inotify_event v5
Shawn Paul Landden [Tue, 23 Dec 2014 21:47:16 +0000 (13:47 -0800)]
util: fix strict aliasing violations in use of struct inotify_event v5

There is alot of cleanup that will have to happen to turn on
-fstrict-aliasing, but I think our code should be "correct" to the rule.

5 years agohwdb: add rule and first entry for PS/2 mice
Peter Hutterer [Tue, 23 Dec 2014 00:14:19 +0000 (10:14 +1000)]
hwdb: add rule and first entry for PS/2 mice

https://bugs.freedesktop.org/show_bug.cgi?id=87037

5 years agohwdb: Microsoft Wireless Laser Mouse 8000 DPI data
Frank Theile [Tue, 23 Dec 2014 21:53:40 +0000 (07:53 +1000)]
hwdb: Microsoft Wireless Laser Mouse 8000 DPI data

https://bugs.freedesktop.org/show_bug.cgi?id=87587

5 years agoupdate TODO
Lennart Poettering [Tue, 23 Dec 2014 20:36:14 +0000 (21:36 +0100)]
update TODO

5 years agoshell-completion: add full support for completing busctl command lines, with services...
Lennart Poettering [Tue, 23 Dec 2014 21:43:16 +0000 (22:43 +0100)]
shell-completion: add full support for completing busctl command lines, with services, objects, interfaces, members, and signatures

5 years agobusctl: when introspecting objects, optionally limit output by interface name
Lennart Poettering [Tue, 23 Dec 2014 21:42:55 +0000 (22:42 +0100)]
busctl: when introspecting objects, optionally limit output by interface name

5 years agogitignore: hide test-lldp files
Lennart Poettering [Tue, 23 Dec 2014 20:34:55 +0000 (21:34 +0100)]
gitignore: hide test-lldp files

5 years agomachined: introduce polkit for OpenLogin() call
Lennart Poettering [Tue, 23 Dec 2014 20:28:22 +0000 (21:28 +0100)]
machined: introduce polkit for OpenLogin() call

This way "machinectl login" can be opened up to run without privileges.

5 years agobus: add missing bus-policy.[ch]
Lennart Poettering [Tue, 23 Dec 2014 20:06:01 +0000 (21:06 +0100)]
bus: add missing bus-policy.[ch]

Accidentally forgot to commit this. Sorry!

5 years agobuild-sys: move core/build.h → shared/build.h
Lennart Poettering [Tue, 23 Dec 2014 18:19:11 +0000 (19:19 +0100)]
build-sys: move core/build.h → shared/build.h

After all, pretty much all our tools include it, and it should hence be
shared.

Also move sysfs-show.h from core/ to login/, since it has no point to
exist in core.

5 years agoupdate TODO
Lennart Poettering [Tue, 23 Dec 2014 18:14:26 +0000 (19:14 +0100)]
update TODO

5 years agomachinectl: rework 'machinectl login' to use OpenMachineLogin()
Lennart Poettering [Tue, 23 Dec 2014 18:14:04 +0000 (19:14 +0100)]
machinectl: rework 'machinectl login' to use OpenMachineLogin()

5 years agomachined: add new call OpenMachineLogin() that starts a getty in a container on a...
Lennart Poettering [Tue, 23 Dec 2014 18:12:49 +0000 (19:12 +0100)]
machined: add new call OpenMachineLogin() that starts a getty in a container on a pty and returns the pty master fd to the client

This is a one-stop solution for "machinectl login", and should simplify
getting logins in containers.

5 years agosd-bus: teach x-container-unix: bus protoocol to connect to the namespace of a PID...
Lennart Poettering [Tue, 23 Dec 2014 18:11:48 +0000 (19:11 +0100)]
sd-bus: teach x-container-unix: bus protoocol to connect to the namespace of a PID instead of a container name

5 years agocondition: don't include files from src/core
Lennart Poettering [Tue, 23 Dec 2014 18:07:01 +0000 (19:07 +0100)]
condition: don't include files from src/core

5 years agoimport: fix compiler warning
Lennart Poettering [Tue, 23 Dec 2014 18:05:23 +0000 (19:05 +0100)]
import: fix compiler warning

5 years agoenv-util: don't include files from src/core/
Lennart Poettering [Tue, 23 Dec 2014 18:04:56 +0000 (19:04 +0100)]
env-util: don't include files from src/core/

5 years agocore: rearrange code so that libsystemd/sd-bus/ does not include header files from...
Lennart Poettering [Tue, 23 Dec 2014 17:36:04 +0000 (18:36 +0100)]
core: rearrange code so that libsystemd/sd-bus/ does not include header files from core

Stuff in src/shared or src/libsystemd should *never* include code from
src/core or any of the tools, so don't do that here either. It's not OK!

5 years agobus-proxyd: ignore errors from sd_bus_creds_get_well_known_names()
Daniel Mack [Tue, 23 Dec 2014 17:36:29 +0000 (18:36 +0100)]
bus-proxyd: ignore errors from sd_bus_creds_get_well_known_names()

sd_bus_creds_get_well_known_names() fails with -ENODATA in case the
message has no names attached, which is intended behavior if the
remote connection didn't own any names at the time of sending.

The function already deals with 'sender_names' being an empty strv,
so we can just continue in such cases.

5 years agobus-proxyd: handle -ESRCH and -ENXIO gracefully
Daniel Mack [Tue, 23 Dec 2014 12:37:52 +0000 (13:37 +0100)]
bus-proxyd: handle -ESRCH and -ENXIO gracefully

Messages to destinations that are not currently owned by any bus connection
will cause kdbus related function to return with either -ENXIO or -ESRCH.

Such conditions should not make the proxyd terminate but send a sane
SD_BUS_ERROR_NAME_HAS_NO_OWNER error reply to the proxied connection.

5 years agoupdate TODO
Lennart Poettering [Tue, 23 Dec 2014 01:11:48 +0000 (02:11 +0100)]
update TODO

5 years agoutil: add allocation loop to gettyname_malloc()
Lennart Poettering [Tue, 23 Dec 2014 01:10:08 +0000 (02:10 +0100)]
util: add allocation loop to gettyname_malloc()

5 years agonspawn,pty: port over to new ptsname_malloc() helper
Lennart Poettering [Tue, 23 Dec 2014 01:02:08 +0000 (02:02 +0100)]
nspawn,pty: port over to new ptsname_malloc() helper

5 years agosystemd-run: support -t mode when combined with -M
Lennart Poettering [Tue, 23 Dec 2014 00:58:49 +0000 (01:58 +0100)]
systemd-run: support -t mode when combined with -M

For that, ask machined for a container PTY and use that.

5 years agomachined: add OpenMachinePTY() bus call for allocating a PTY device within a container
Lennart Poettering [Mon, 22 Dec 2014 20:17:29 +0000 (21:17 +0100)]
machined: add OpenMachinePTY() bus call for allocating a PTY device within a container

Then, port "machinectl" over to make use of it.

5 years agosystemd-run: add --quiet mode to suppress informational message on TTY usage
Lennart Poettering [Mon, 22 Dec 2014 19:39:10 +0000 (20:39 +0100)]
systemd-run: add --quiet mode to suppress informational message on TTY usage

5 years agomachinectl,nspawn: don't print extra final newline if pty terminal output was newline...
Lennart Poettering [Mon, 22 Dec 2014 19:33:45 +0000 (20:33 +0100)]
machinectl,nspawn: don't print extra final newline if pty terminal output was newline-terinated anyway

5 years agorun: add a new "-t" mode for invoking a binary on an allocated TTY
Lennart Poettering [Mon, 22 Dec 2014 18:45:32 +0000 (19:45 +0100)]
run: add a new "-t" mode for invoking a binary on an allocated TTY

5 years agoimport: rename 'poll-dck' to 'pull-dkr'
Lennart Poettering [Mon, 22 Dec 2014 18:42:27 +0000 (19:42 +0100)]
import: rename 'poll-dck' to 'pull-dkr'

I figure "pull-dck" is not a good name, given that one could certainly
read the verb in a way that might be funny for 16year-olds. ;-)

Also, don't hardcode the index URL to use, make it runtime and configure
time configurable instead.

5 years agoshared: json - support escaping utf16 surrogate pairs
Tom Gundersen [Mon, 22 Dec 2014 13:53:40 +0000 (14:53 +0100)]
shared: json - support escaping utf16 surrogate pairs

We originally only supported escaping ucs2 encoded characters (as \uxxxx). This
only covers the BMP. Support escaping also utf16 surrogate pairs (on the form
\uxxxx\uyyyy) to cover all of unicode.

5 years agoshared: utf8 - support decoding the full utf16
Tom Gundersen [Mon, 22 Dec 2014 11:57:05 +0000 (12:57 +0100)]
shared: utf8 - support decoding the full utf16

We originally only supported the BMP (i.e., we treated UTF-16 as UCS-2).

5 years agoshared: utf8 - support ucs4 -> utf8
Tom Gundersen [Sun, 21 Dec 2014 23:58:26 +0000 (00:58 +0100)]
shared: utf8 - support ucs4 -> utf8

Originally we only supported ucs2, so move the ucs4 version from libsystemd-terminal to shared
and use that everywhere.

5 years agosd-bus: ignore KDBUS_ITEM_TIMESTAMP in kernel messages
Daniel Mack [Mon, 22 Dec 2014 18:59:53 +0000 (19:59 +0100)]
sd-bus: ignore KDBUS_ITEM_TIMESTAMP in kernel messages

Kernel notifications carry a timestamp now, so make sure
bus_kernel_translate_message() doesn't complain when it stumbles across
them.

5 years agobusname: fix CMD_FREE ioctl
Daniel Mack [Mon, 22 Dec 2014 15:51:15 +0000 (16:51 +0100)]
busname: fix CMD_FREE ioctl

The KDBUS_CMD_FREE ioctl struct has a size field now, which needs to be set.

5 years agoverbs: fix typo in error message
Dave Reisner [Mon, 22 Dec 2014 02:28:49 +0000 (21:28 -0500)]
verbs: fix typo in error message

5 years agohwdb: Lenovo USB mouse MO28UOL DPI data
Frank Theile [Sun, 21 Dec 2014 22:18:55 +0000 (08:18 +1000)]
hwdb: Lenovo USB mouse MO28UOL DPI data

https://bugs.freedesktop.org/show_bug.cgi?id=87504

5 years agosd-bus: sync kdbus.h (ABI break)
Daniel Mack [Sat, 20 Dec 2014 18:23:49 +0000 (19:23 +0100)]
sd-bus: sync kdbus.h (ABI break)

Sync kdbus.h with upstream changes:

  * Two optional cancellation points where added for synchronously
    blocking KDBUS_CMD_SEND commands: A sigmask to change the mask
    of accepted signals before the task is put to sleep, and a
    generic file descriptor that can be written to, in order to cancel
    the command. Both methods are currently unused.

  * The KDBUS_CMD_CANCEL ioctl was removed. sd-bus was never using
    that command, so there's no change needed.

  * Some kerneldoc fixes

5 years agobuild: add option to disable hwdb
Umut Tezduyar Lindskog [Fri, 19 Dec 2014 10:47:30 +0000 (11:47 +0100)]
build: add option to disable hwdb

[tomegun: fix Makefile-man.am, based on fix from Michael Biebl]

5 years agosd-lldp: minor header cleanup
Tom Gundersen [Fri, 19 Dec 2014 21:42:03 +0000 (22:42 +0100)]
sd-lldp: minor header cleanup

 * (potentially) public headers must reside in src/systemd/ (not in
   src/libsystemd*)
 * some private (not prefixed with sd_) functions moved from sd-lldp.h to
   lldp-internal.h
 * introduce lldp-util.h for the cleanup macro, as these should not be public
 * rename the cleanup macro, we always name them _cleanup_foo_, never
   _cleanup_sd_foo_
 * mark some function arguments as 'const'

5 years agoupdate TODO
Lennart Poettering [Fri, 19 Dec 2014 19:44:49 +0000 (20:44 +0100)]
update TODO

5 years agomachined: add a full bus object for images
Lennart Poettering [Fri, 19 Dec 2014 19:43:18 +0000 (20:43 +0100)]
machined: add a full bus object for images

5 years agomachined: add new GetImage() bus call for retrieving the bus path for an image
Lennart Poettering [Fri, 19 Dec 2014 19:07:23 +0000 (20:07 +0100)]
machined: add new GetImage() bus call for retrieving the bus path for an image

5 years agosysv-generator: properly add Makefile symlink
Lennart Poettering [Fri, 19 Dec 2014 19:04:55 +0000 (20:04 +0100)]
sysv-generator: properly add Makefile symlink

5 years agoutil: rename ignore_file() to hidden_file()
Lennart Poettering [Fri, 19 Dec 2014 19:03:36 +0000 (20:03 +0100)]
util: rename ignore_file() to hidden_file()

hidden_file() is a bit more precise, since dot files usually shouldn't
be ignored, but certainly be considered hidden.

5 years agoupdate TODO
Lennart Poettering [Fri, 19 Dec 2014 18:19:20 +0000 (19:19 +0100)]
update TODO

5 years agomachinectl: port machinectl to new verbs logic
Lennart Poettering [Fri, 19 Dec 2014 18:19:05 +0000 (19:19 +0100)]
machinectl: port machinectl to new verbs logic

5 years agoimport: Verb[] array can be static, too
Lennart Poettering [Fri, 19 Dec 2014 18:18:48 +0000 (19:18 +0100)]
import: Verb[] array can be static, too

5 years agoverbs: when invoking the default verb, pass a faked argv array, with just the verb...
Lennart Poettering [Fri, 19 Dec 2014 18:17:52 +0000 (19:17 +0100)]
verbs: when invoking the default verb, pass a faked argv array, with just the verb in it

That way the dispatcher calls know how they got called.

5 years agomachined/machinectl: add logic to show list of available images
Lennart Poettering [Fri, 19 Dec 2014 17:42:50 +0000 (18:42 +0100)]
machined/machinectl: add logic to show list of available images

This adds a new bus call to machined that enumerates /var/lib/container
and returns all trees stored in it, distuingishing three types:

        - GPT disk images, which are files suffixed with ".gpt"
        - directory trees
        - btrfs subvolumes

5 years agoutil: when creating temporary filename for atomic creation of files, add an extra...
Lennart Poettering [Fri, 19 Dec 2014 17:40:23 +0000 (18:40 +0100)]
util: when creating temporary filename for atomic creation of files, add an extra "#" to the name

That way, we have a simple, somewhat reliable way to detect such
temporary files, by simply checking if they start with ".#".

5 years agojournal: skipping of exhausted journal files is bad if direction changed
Michal Schmidt [Fri, 19 Dec 2014 16:11:22 +0000 (17:11 +0100)]
journal: skipping of exhausted journal files is bad if direction changed

EOF is meaningless if the direction of iteration changes.
Move the EOF optimization under the direction check.

This fixes test-journal-interleaving for me.

Thanks to Filipe Brandenburger for telling me about the failure.

5 years agojournal: make next_with_matches() always use f->current_offset
Michal Schmidt [Fri, 19 Dec 2014 13:42:55 +0000 (14:42 +0100)]
journal: make next_with_matches() always use f->current_offset

next_with_matches() is odd in that its "unit64_t *offset" parameter is
both input and output. In other it's purely for output.

The function is called from two places in next_beyond_location(). In
both of them "&cp" is used as the argument and in both cases cp is
guaranteed to equal f->current_offset.

Let's just have next_with_matches() ignore "*offset" on input and
operate with f->current_offset.

I did not investigate why it is, but it makes my usual benchmark run
reproducibly faster:

$ time ./journalctl --since=2014-06-01 --until=2014-07-01 > /dev/null

real    0m4.032s
user    0m3.896s
sys     0m0.135s

(Compare to preceding commit, where real was 4.4s.)

5 years agojournal: fix skipping of duplicate entries in iteration
Michal Schmidt [Fri, 19 Dec 2014 14:05:30 +0000 (15:05 +0100)]
journal: fix skipping of duplicate entries in iteration

I accidentally broke the detection of duplicate entries in 7943f42275
"journal: optimize iteration by returning previously found candidate
entry".

When we have a known location of a candidate entry, we must not return
from next_beyond_location() immediately. We must go through the
duplicates detection to make sure the candidate differs from the
already iterated entry.

This fix slows down iteration a bit, but it's still faster than it
was before the rework.

$ time ./journalctl --since=2014-06-01 --until=2014-07-01 > /dev/null

real    0m4.448s
user    0m4.298s
sys     0m0.149s

(Compare with results from commit 7943f42275, where real was 5.3s before
the rework.)

5 years agonetworkd: link - plug leak
Tom Gundersen [Fri, 19 Dec 2014 07:34:04 +0000 (08:34 +0100)]
networkd: link - plug leak

5 years agonetworkctl: lldp - respect arg_legend
Tom Gundersen [Fri, 19 Dec 2014 07:33:46 +0000 (08:33 +0100)]
networkctl: lldp - respect arg_legend

5 years agoLLDP: Add support for networkctl
Susant Sahani [Thu, 11 Dec 2014 04:29:55 +0000 (09:59 +0530)]
LLDP: Add support for networkctl

5 years agonetworkd: integrate LLDP
Susant Sahani [Sun, 23 Nov 2014 04:26:14 +0000 (09:56 +0530)]
networkd: integrate LLDP

This patch integrates LLDP with networkd.

Example conf:
file : lldp.network

[Match]
Name=em1

[Network]
LLDP=yes

5 years agonetworkd: Introduce Link Layer Discovery Protocol (LLDP)
Susant Sahani [Sun, 23 Nov 2014 04:16:36 +0000 (09:46 +0530)]
networkd: Introduce Link Layer Discovery Protocol (LLDP)

This patch introduces LLDP support to networkd. it implements the
receiver side of the protocol.

The Link Layer Discovery Protocol (LLDP) is an industry-standard,
vendor-neutral method to allow networked devices to advertise
capabilities, identity, and other information onto a LAN. The Layer 2
protocol, detailed in IEEE 802.1AB-2005.LLDP allows network devices
that operate at the lower layers of a protocol stack (such as
Layer 2 bridges and switches) to learn some of the capabilities
and characteristics of LAN devices available to higher
layer protocols.

5 years agonetworkctl: port to verbs helper
Tom Gundersen [Fri, 19 Dec 2014 02:16:45 +0000 (03:16 +0100)]
networkctl: port to verbs helper

5 years agosystemd-hwdb: port to new verbs helper
Tom Gundersen [Fri, 19 Dec 2014 02:01:27 +0000 (03:01 +0100)]
systemd-hwdb: port to new verbs helper