chiark / gitweb /
elogind.git
5 years agojournal/compress: add stream compression/decompression functions
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jun 2014 01:24:46 +0000 (21:24 -0400)]
journal/compress: add stream compression/decompression functions

5 years agojournal/compress: simplify compress_blob
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jun 2014 01:24:09 +0000 (21:24 -0400)]
journal/compress: simplify compress_blob

5 years agoshutdown: rework messages during shutdown
Zbigniew Jędrzejewski-Szmek [Thu, 26 Jun 2014 05:41:04 +0000 (01:41 -0400)]
shutdown: rework messages during shutdown

When running in 'quiet' mode, the only message printed from shutdown
binary would be 'Cannot finalize remaining file systems and devices,
giving up.', the only log line at error level before switch back to
initramfs. This is misleading, because in initramfs everything will
be cleaned up properly.

Avoid printing anything at error level before the attempt to switch
back to initramfs. Rework the messages to contain a bit more
information what is still remaining, to help people diagnose shutdown
issues.

5 years agosysv-generator: fix incorect ordering of Wants
Thomas Hindoe Paaboel Andersen [Wed, 25 Jun 2014 22:36:43 +0000 (00:36 +0200)]
sysv-generator: fix incorect ordering of Wants

5 years agosystemctl: add new "is-system-running" command to check whether system is fully up
Lennart Poettering [Wed, 25 Jun 2014 10:31:03 +0000 (12:31 +0200)]
systemctl: add new "is-system-running" command to check whether system is fully up

https://bugs.freedesktop.org/show_bug.cgi?id=66926

5 years agoupdate TODO
Lennart Poettering [Wed, 25 Jun 2014 08:07:20 +0000 (10:07 +0200)]
update TODO

5 years agofsck: consider a fsck implementation linked to /bin/true non-existant
Lennart Poettering [Tue, 24 Jun 2014 17:37:22 +0000 (19:37 +0200)]
fsck: consider a fsck implementation linked to /bin/true non-existant

5 years agoupdate TODO
Lennart Poettering [Tue, 24 Jun 2014 17:34:27 +0000 (19:34 +0200)]
update TODO

5 years agoTrim TODO
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jun 2014 05:46:30 +0000 (01:46 -0400)]
Trim TODO

5 years agotests: add test-compress
Ronny Chevalier [Tue, 24 Jun 2014 18:42:29 +0000 (20:42 +0200)]
tests: add test-compress

5 years agosysv-generator: rename PidFile to PIDFile
Thomas Hindoe Paaboel Andersen [Tue, 24 Jun 2014 21:07:48 +0000 (23:07 +0200)]
sysv-generator: rename PidFile to PIDFile

Spotted by Alexey Shabalin

5 years agouse more _cleanup_ macro
Ronny Chevalier [Tue, 24 Jun 2014 17:00:32 +0000 (19:00 +0200)]
use more _cleanup_ macro

5 years agosd-dhcp6-client: use %m instead of strerror(errno)
Ronny Chevalier [Tue, 24 Jun 2014 17:00:31 +0000 (19:00 +0200)]
sd-dhcp6-client: use %m instead of strerror(errno)

5 years agoswitch-root: create essential base directories at system bootup
Kay Sievers [Tue, 24 Jun 2014 16:10:30 +0000 (18:10 +0200)]
switch-root: create essential base directories at system bootup

This allows us to bootup a rootfs with a /usr directory only.

5 years agosd-dhcp-client: return NULL from _unref() like the other sd-* libraries
Tom Gundersen [Thu, 22 May 2014 13:18:28 +0000 (15:18 +0200)]
sd-dhcp-client: return NULL from _unref() like the other sd-* libraries

Let's keep this behavior consistent across our libraries.

In order to keep the refcounting working, a DONT_DESTROY macro similar
to the one in sd-bus was introduced.

5 years agonspawn: create essential base directories at system bootup
Kay Sievers [Tue, 24 Jun 2014 11:30:11 +0000 (13:30 +0200)]
nspawn: create essential base directories at system bootup

This allows us to bootup a rootfs with a /usr directory only.

5 years agoRevert "Add systemd-coredumpctl as an alias for coredumpctl"
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jun 2014 03:09:08 +0000 (23:09 -0400)]
Revert "Add systemd-coredumpctl as an alias for coredumpctl"

This reverts the documentation part of commit
dfdd0e0730385eef08f019863fd41168b05b6ab0.

5 years agocoredump: log coredump even if core dumping fails
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jun 2014 03:02:19 +0000 (23:02 -0400)]
coredump: log coredump even if core dumping fails

Journal might be functional even if we cannot write to
/var/lib/systemd/coredump.

5 years agocoredump: retrieve comm information from /proc
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jun 2014 00:18:16 +0000 (20:18 -0400)]
coredump: retrieve comm information from /proc

Kernel mangles comm information in an irreversible way when comm
constains repeated spaces. Retrieve comm information from /proc, and
only fallback to the information provided on the commandline when
retrieving information from /proc fails.

Add exe information to the list of saved xattr.

https://bugs.freedesktop.org/show_bug.cgi?id=62043

5 years agofstab-generator: simplify add_root_mount
Zbigniew Jędrzejewski-Szmek [Mon, 23 Jun 2014 18:11:30 +0000 (14:11 -0400)]
fstab-generator: simplify add_root_mount

5 years agoman: fix path in crypttab(5)
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jun 2014 03:07:53 +0000 (23:07 -0400)]
man: fix path in crypttab(5)

https://bugs.freedesktop.org/show_bug.cgi?id=75816

5 years agobuild-sys: do not run coverage if build failed
Ronny Chevalier [Mon, 23 Jun 2014 19:28:23 +0000 (21:28 +0200)]
build-sys: do not run coverage if build failed

5 years agotests: add test-ratelimit
Ronny Chevalier [Mon, 23 Jun 2014 19:28:22 +0000 (21:28 +0200)]
tests: add test-ratelimit

5 years agotests: add tests to test-unit-name
Ronny Chevalier [Mon, 23 Jun 2014 19:28:21 +0000 (21:28 +0200)]
tests: add tests to test-unit-name

add tests for:
  - unit_instance_is_valid
  - unit_prefix_is_valid
  - unit_name_change_suffix
  - unit_name_build
  - unit_name_is_instance
  - build_subslice
  - unit_name_to_instance
  - unit_name_escape

5 years agocryptsetup: don't add unit dependency on /dev/null devices when it is listed as passw...
Lennart Poettering [Mon, 23 Jun 2014 17:18:44 +0000 (19:18 +0200)]
cryptsetup: don't add unit dependency on /dev/null devices when it is listed as password file

As special magic, don't create device dependencies for /dev/null. Of
course, there might be similar devices we might want to include, but
given that none of them really make sense to specify as password source
there's really no point in checking for anything else here.

https://bugs.freedesktop.org/show_bug.cgi?id=75816

5 years agocore: You can not put the cached result of use_smack fct, as we are not sure the...
Ronan Le Martret [Tue, 22 Apr 2014 08:33:25 +0000 (10:33 +0200)]
core: You can not put the cached result of use_smack fct, as we are not sure the "/sys" is mounted. So we should mount "sys" before "/proc"

https://bugs.freedesktop.org/show_bug.cgi?id=77646

5 years agocore: make sure Environment fields passed in for transient units are properly written...
Hristo Venev [Mon, 23 Jun 2014 16:53:04 +0000 (18:53 +0200)]
core: make sure Environment fields passed in for transient units are properly written to unit files

https://bugs.freedesktop.org/show_bug.cgi?id=76744

5 years agovconsole: also copy character maps (not just fonts) from vt1 to vt2, vt3, ...
Carl Schaefer [Mon, 23 Jun 2014 16:23:48 +0000 (18:23 +0200)]
vconsole: also copy character maps (not just fonts) from vt1 to vt2, vt3, ...

https://bugs.freedesktop.org/show_bug.cgi?id=78796

5 years agocoredump: never write more than the configured processing size limit to disk
Lennart Poettering [Mon, 23 Jun 2014 14:28:05 +0000 (16:28 +0200)]
coredump: never write more than the configured processing size limit to disk

5 years agocoredumpctl: show comm name next to PID
Lennart Poettering [Mon, 23 Jun 2014 13:55:24 +0000 (15:55 +0200)]
coredumpctl: show comm name next to PID

5 years agocoredump: quit early if we cannot store ay coredump to disk
Lennart Poettering [Mon, 23 Jun 2014 13:53:03 +0000 (15:53 +0200)]
coredump: quit early if we cannot store ay coredump to disk

5 years agocoredumpctl: include timestamp information in "coredumpctl info" output
Lennart Poettering [Mon, 23 Jun 2014 13:51:09 +0000 (15:51 +0200)]
coredumpctl: include timestamp information in "coredumpctl info" output

5 years agoREADME: mention that elfutils is an (optional) dependency now
Lennart Poettering [Mon, 23 Jun 2014 10:42:17 +0000 (12:42 +0200)]
README: mention that elfutils is an (optional) dependency now

5 years agocoredump: also escape spaces in comm fields when formatting file names
Lennart Poettering [Mon, 23 Jun 2014 10:39:53 +0000 (12:39 +0200)]
coredump: also escape spaces in comm fields when formatting file names

5 years agoREADME: add gobject-introspection
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 18:52:43 +0000 (14:52 -0400)]
README: add gobject-introspection

5 years agocore/snapshot: log info when snapshots are created and removed
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 18:20:08 +0000 (14:20 -0400)]
core/snapshot: log info when snapshots are created and removed

Snapshot mechanism is not used very much, but snapshot creation/destruction
should be at least as verbose as normal unit starting/stopping.

5 years agocore/transaction: avoid misleading error message when unit not found
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 18:04:23 +0000 (14:04 -0400)]
core/transaction: avoid misleading error message when unit not found

There's no point in telling the user to look at the logs when
an attempt to load the unit file failed with ENOENT.

https://bugzilla.redhat.com/show_bug.cgi?id=996133

5 years agocore/transaction: reindent and split very long lines
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 18:00:36 +0000 (14:00 -0400)]
core/transaction: reindent and split very long lines

5 years agoAdd systemd-coredumpctl as an alias for coredumpctl
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 17:38:48 +0000 (13:38 -0400)]
Add systemd-coredumpctl as an alias for coredumpctl

Should make the transition easier for exisiting users.

5 years agoreadahead: avoid gcc warning about format
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 17:21:47 +0000 (13:21 -0400)]
readahead: avoid gcc warning about format

src/readahead/readahead-common.c:55:17: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 7 has type ‘__off64_t’ [-Wformat=]
                 log_debug("Not preloading file %s with size out of bounds %zu", fn, st->st_size);
                 ^

5 years agodhcp-network: don't bother with IP fragments
Michal Sekletar [Thu, 19 Jun 2014 16:59:37 +0000 (18:59 +0200)]
dhcp-network: don't bother with IP fragments

5 years agobuild-sys: require elfutils >= 158
Michael Marineau [Fri, 20 Jun 2014 20:46:04 +0000 (13:46 -0700)]
build-sys: require elfutils >= 158

The recently added stacktrace support in 8d4e028f uses functions added
in elfutils 158. Check for one of the new functions to avoid attempting
to build against older versions.

5 years agoman: untabify systemd-resolved.service.xml
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jun 2014 15:50:33 +0000 (11:50 -0400)]
man: untabify systemd-resolved.service.xml

5 years agofix systemd-resolved reference in man page
Jonathan Boulle [Fri, 20 Jun 2014 21:46:18 +0000 (14:46 -0700)]
fix systemd-resolved reference in man page

Guess this was missed in the copy-paste :-)

5 years agofix in_addr_prefix_intersect for 32bits
Marc-Antoine Perennou [Sun, 22 Jun 2014 10:36:03 +0000 (19:36 +0900)]
fix in_addr_prefix_intersect for 32bits

shifting from a non fixed number of bits >= to the size of the type
leads to weird results, handle the special case of << 32 to fix it.

This was causing a test failure from test-socket-util:
Assertion 'in_addr_prefix_intersect(f, &ua, apl, &ub, bpl) == result' failed at
/var/tmp/paludis/build/sys-apps-systemd-scm/work/systemd-scm/src/test/test-socket-util.c:147, function
test_in_addr_prefix_intersect_one(). Aborting.

Minimal reproducer:

paludisbuild@Lou /tmp $ cat test.c
static void test(unsigned m) {
        unsigned nm = 0xFFFFFFFFUL << (32-m);
        printf("%u: %x\n", m, nm);
}

int main (void) {
        test(1);
        test(0);
        return 0;
}
paludisbuild@Lou /tmp $ gcc -m32 -std=gnu99 test.c -o test32
paludisbuild@Lou /tmp $ ./test32
1: 80000000
0: ffffffff
paludisbuild@Lou /tmp $ gcc -std=gnu99 test.c -o test64
paludisbuild@Lou /tmp $ ./test64
1: 80000000
0: 0

5 years agoupdate .gitignore
Ronny Chevalier [Sun, 22 Jun 2014 12:53:24 +0000 (14:53 +0200)]
update .gitignore

5 years agoconsistently order cleanup attribute before type
Thomas Hindoe Paaboel Andersen [Sat, 21 Jun 2014 03:55:17 +0000 (05:55 +0200)]
consistently order cleanup attribute before type

5 years agotests: add test_fdset_remove
Ronny Chevalier [Sat, 21 Jun 2014 20:07:12 +0000 (22:07 +0200)]
tests: add test_fdset_remove

5 years agotests: add test-async
Ronny Chevalier [Sat, 21 Jun 2014 20:07:11 +0000 (22:07 +0200)]
tests: add test-async

5 years agotests: add test-capability
Ronny Chevalier [Sat, 21 Jun 2014 20:07:10 +0000 (22:07 +0200)]
tests: add test-capability

5 years agobuild-sys: add -pthread flag for libsystemd-shared
Ronny Chevalier [Sat, 21 Jun 2014 20:07:09 +0000 (22:07 +0200)]
build-sys: add -pthread flag for libsystemd-shared

src/shared/async.c uses pthread so it will fail at link time if we link
only to libsystemd-shared and use async

5 years agobuild-sys: replace nm with $(NM)
Kay Sievers [Sat, 21 Jun 2014 14:50:11 +0000 (16:50 +0200)]
build-sys: replace nm with $(NM)

5 years agogudev: replace regex with sym file
Kay Sievers [Sat, 21 Jun 2014 13:53:58 +0000 (15:53 +0200)]
gudev: replace regex with sym file

5 years agopam_systemd: replace regex with sym file
Kay Sievers [Sat, 21 Jun 2014 13:45:49 +0000 (15:45 +0200)]
pam_systemd: replace regex with sym file

5 years agopam_systemd: rename source file to match the module
Kay Sievers [Sat, 21 Jun 2014 13:44:14 +0000 (15:44 +0200)]
pam_systemd: rename source file to match the module

5 years agosd-dhcp-server: change default lease time form 1m to 1h
Tom Gundersen [Sat, 21 Jun 2014 13:26:41 +0000 (15:26 +0200)]
sd-dhcp-server: change default lease time form 1m to 1h

The short lease was useful for testing, but in real-world usage it is pointless to keep leases
this short. That said, the cost of lease renewal is really low, so we keep the lease still
relatively short at one hour to not get into hard-to-hit problems with lease exhaustion etc.

5 years agosd-dhcp-server: fix broadcast of DHCP packets
Tom Gundersen [Sat, 21 Jun 2014 12:39:36 +0000 (14:39 +0200)]
sd-dhcp-server: fix broadcast of DHCP packets

The destination IP address should be INADDR_BROADCAST, but was
accidentally left as INADDR_ANY.

5 years agoutil: treat fuse.sshfs as a network filesystem
Zbigniew Jędrzejewski-Szmek [Sat, 21 Jun 2014 02:43:49 +0000 (22:43 -0400)]
util: treat fuse.sshfs as a network filesystem

https://bugs.freedesktop.org/show_bug.cgi?id=73727

5 years agomissing.h: add various network enums
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 23:45:45 +0000 (19:45 -0400)]
missing.h: add various network enums

We used to check if e.g. IFLA_BOND_MAX is defined and provide fallback
values in missing.h is it wasn't. But over time, various kernel
versions added IFLA_* defines, so checking for IFLA_BOND_MAX is not
enough if the kernel is new enough to have some of them but too old to
have all. In case we detect that the latest known enum value is
missing, #define most of them.

https://bugs.freedesktop.org/show_bug.cgi?id=80095

5 years agobuild-sys: fail if python support requested but not found
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 22:14:22 +0000 (18:14 -0400)]
build-sys: fail if python support requested but not found

5 years agobuild-sys: check that compat-libs are enabled for "make dist"
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:54 +0000 (20:54 -0700)]
build-sys: check that compat-libs are enabled for "make dist"

Running "make dist" requires --enable-compat-libs since DIST_SOURCES will list
generated files such as libsystemd-daemon.c.

Tested:
  $ ./configure && make && make dist
  *** compat-libs must be enabled in order to make dist
  make: *** [dist-check-compat-libs] Error 1

5 years agobuild-sys: check that python is enabled for "make dist"
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:53 +0000 (20:54 -0700)]
build-sys: check that python is enabled for "make dist"

Running "make dist" requires Python support since some of the man page sources
(such as man/systemd.index.xml and man/systemd.directives.xml) are generated by
Python scripts, so break "make dist" and give an useful error message when
Python or the Python lxml module is not available.

Tested:
  $ ./configure --without-python && make && make dist
  *** python and python-lxml module must be installed and enabled in order to make dist
  make: *** [dist-check-python] Error 1

5 years agobuild-sys: configure --with-python when running distcheck
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:52 +0000 (20:54 -0700)]
build-sys: configure --with-python when running distcheck

Python support is pretty much essential to create man pages, so we should make
sure that distcheck will request it during configure.

Tested: Successfully ran "make distcheck" and confirmed --with-python was
present in the ./configure run inside the unpacked distribution directory.

5 years agobuild-sys: add verbosity to python-lxml detection in ./configure
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:50 +0000 (20:54 -0700)]
build-sys: add verbosity to python-lxml detection in ./configure

Be verbose when checking if Python module lxml is available.  Also warn that
Python support will be disabled when the lxml module is not present.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80005

Tested:
- Without python-lxml package installed:
  $ ./configure
  checking for python extension module directory... ${exec_prefix}/lib64/python2.7/site-packages
  checking for python lxml module... no
  configure: WARNING: *** python support requires python-xml module installed

- With python-lxml package installed:
  $ ./configure
  checking for python extension module directory... ${exec_prefix}/lib64/python2.7/site-packages
  checking for python lxml module... yes
  checking for PYTHON_DEVEL... yes
  ...
          Python:                  yes
          Python Headers:          yes

5 years agobuild-sys: do not include id128-constants.h in the dist archive
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:47 +0000 (20:54 -0700)]
build-sys: do not include id128-constants.h in the dist archive

File src/python-systemd/id128-constants.h is auto generated and its generation
does not require special tools, only sed.  There is no point in bundling it in
the distribution archive, so let's mark it as nodist_ to have it excluded.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80006

Tested: Successfully ran "make dist" after ./configure --without-python.

5 years agoutil: do not strip /dev prefix twice
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 22:44:39 +0000 (18:44 -0400)]
util: do not strip /dev prefix twice

5 years agoRemove libattr mentions from README
Cristian Rodríguez [Thu, 12 Jun 2014 19:40:30 +0000 (15:40 -0400)]
Remove libattr mentions from README

It is no longer required.

5 years agosd-dhcp-server: remove unused cleanup function
Thomas Hindoe Paaboel Andersen [Fri, 20 Jun 2014 17:32:51 +0000 (19:32 +0200)]
sd-dhcp-server: remove unused cleanup function

Removes _cleanup_dhcp_lease_free_. While the automatic cleanup
functions are great to have this one is never used and causes
a warning in clang.

5 years agocore: clean-up signal reset logic when reexec
Lennart Poettering [Fri, 20 Jun 2014 14:58:21 +0000 (16:58 +0200)]
core: clean-up signal reset logic when reexec

There's no need to save the old sigmask, if we are going to die. Let's
simplify this. Also, reset all the signal handlers, so that we don't
leave SIG_IGN set for some of them across reexec.

5 years agotmpfiles: copy/link /usr/share/factory/ files when the source argument is omitted
Kay Sievers [Fri, 20 Jun 2014 13:57:43 +0000 (15:57 +0200)]
tmpfiles: copy/link /usr/share/factory/ files when the source argument is omitted

5 years agopo: add German translation
Benjamin Steinwender [Sun, 8 Jun 2014 16:39:50 +0000 (18:39 +0200)]
po: add German translation

https://bugs.freedesktop.org/show_bug.cgi?id=79430

5 years agobuild-sys: fix indentation in make-man-rules generated output
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:48 +0000 (20:54 -0700)]
build-sys: fix indentation in make-man-rules generated output

This fixes the footer where 7 spaces were used on the first line of EXTRA_DIST,
but a Tab was clearly intended.

5 years agobuild-sys: add sysusers.d/systemd.conf to CLEANFILES
Filipe Brandenburger [Tue, 17 Jun 2014 03:54:46 +0000 (20:54 -0700)]
build-sys: add sysusers.d/systemd.conf to CLEANFILES

The sysusers.d/systemd.conf configuration file was originally introduced in
commit 1b99214789101, but it was not marked for cleanup.  This caused distcheck
to complain about the file not being removed by distcleam.

Tested: Successfully ran "make distcheck" with this patchset.

5 years agosysusers.d - fix typo in user definition file
Jonathan Boulle [Tue, 17 Jun 2014 00:57:05 +0000 (17:57 -0700)]
sysusers.d - fix typo in user definition file

5 years agodebug-generator: add new kernel cmdline option systemd.wants= to add units to the...
Lennart Poettering [Fri, 20 Jun 2014 11:30:52 +0000 (13:30 +0200)]
debug-generator: add new kernel cmdline option systemd.wants= to add units to the initial transaction

5 years agonetworkd: link - fix memleak of icmp6 struct
Tom Gundersen [Fri, 20 Jun 2014 11:04:02 +0000 (13:04 +0200)]
networkd: link - fix memleak of icmp6 struct

5 years agonetworkd: veth - fix creation of veth netdev
Tom Gundersen [Fri, 20 Jun 2014 10:59:22 +0000 (12:59 +0200)]
networkd: veth - fix creation of veth netdev

Avoid freeing the netdev structure in the cleanup macro.

5 years agoshared: fix search_and_fopen with alternate roots
Michael Marineau [Fri, 20 Jun 2014 02:07:06 +0000 (19:07 -0700)]
shared: fix search_and_fopen with alternate roots

Update for the current behavior of path_strv_resolve which now returns
paths relative to the given root, not the full absolute paths.

5 years agotest: ensure conf_files_list returns absolute paths
Michael Marineau [Fri, 20 Jun 2014 02:07:05 +0000 (19:07 -0700)]
test: ensure conf_files_list returns absolute paths

5 years agoconf-files: include root in returned file paths
Michael Marineau [Fri, 20 Jun 2014 02:07:04 +0000 (19:07 -0700)]
conf-files: include root in returned file paths

This restores the original root handling logic that was present prior to
112cfb18 when path expansion moved to path_strv_canonicalize_absolute.
That behavior partially went away in 12ed81d9.

Alternatively all users of conf_files_list* could be updated to
concatenate the paths themselves as unit_file_query_preset did but since
no user needs the un-concatenated form that is pointless duplication.

5 years agotest: unit test for using alternate roots with path_strv_resolve
Michael Marineau [Fri, 20 Jun 2014 02:07:03 +0000 (19:07 -0700)]
test: unit test for using alternate roots with path_strv_resolve

5 years agoshared: rename path_strv_canonicalize_absolute functions
Michael Marineau [Fri, 20 Jun 2014 02:07:02 +0000 (19:07 -0700)]
shared: rename path_strv_canonicalize_absolute functions

Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list
relative to the given root directory instead of resolving paths to their
true location as the name implies. To better reflect this behavior
rename to the less strongly worded path_strv_resolve.

5 years agogetty-generator: properly escape instance names
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 02:02:55 +0000 (22:02 -0400)]
getty-generator: properly escape instance names

Otherwise the add_symlink() function tries to make directories for
each slash even for the slash after the @ symbol in the final link
name, failing for /dev/3270/tty1.

Based on a patch by Werner Fink <werner@suse.de>.

5 years agogetty-generator: use strappenda
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 01:48:32 +0000 (21:48 -0400)]
getty-generator: use strappenda

Allocating on the stack should be fine for the fixed number
of items.

5 years agoman: also describe an udev rule for bridge sysctl
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 01:13:56 +0000 (21:13 -0400)]
man: also describe an udev rule for bridge sysctl

5 years agoman: document statically loading modules for sysctl settings
Zbigniew Jędrzejewski-Szmek [Fri, 20 Jun 2014 00:43:56 +0000 (20:43 -0400)]
man: document statically loading modules for sysctl settings

https://bugzilla.redhat.com/show_bug.cgi?id=1022977
https://bugzilla.novell.com/show_bug.cgi?id=725412

5 years agounits/systemd-sysctl.service.in: run after load-modules
Cristian Rodríguez [Sat, 23 Mar 2013 02:54:16 +0000 (03:54 +0100)]
units/systemd-sysctl.service.in: run after load-modules

Modules might or will register new sysctl options.

[zj: This mechanism of adding modules just to reliably set sysctl
attributes is not ideal. Nevertheless, sysctl for dynamically created
attributes is simply broken, and this is the easiest workaround.]

https://bugzilla.redhat.com/show_bug.cgi?id=1022977
https://bugzilla.novell.com/show_bug.cgi?id=725412

5 years agoutil.c: simplify rm_rf_children_dangerous
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jun 2014 16:43:02 +0000 (12:43 -0400)]
util.c: simplify rm_rf_children_dangerous

5 years agotests: add tests for strv_extendf
Ronny Chevalier [Thu, 19 Jun 2014 22:25:58 +0000 (00:25 +0200)]
tests: add tests for strv_extendf

5 years agotests: add tests to test-util
Ronny Chevalier [Thu, 19 Jun 2014 22:25:34 +0000 (00:25 +0200)]
tests: add tests to test-util

add tests for:
  - filename_is_safe
  - ascii_strlower
  - files_same
  - is_valid_documentation_url
  - file_in_same_dir
  - endswith
  - close_nointr
  - unlink_noerrno
  - readlink_and_make_absolute
  - read_one_char
  - ignore_signals
  - strshorten

5 years agotests: add missing return
Ronny Chevalier [Thu, 19 Jun 2014 22:26:12 +0000 (00:26 +0200)]
tests: add missing return

5 years agotests: fix test-icmp6-rs
Ronny Chevalier [Thu, 19 Jun 2014 17:32:05 +0000 (19:32 +0200)]
tests: fix test-icmp6-rs

Don't close the fd given to sd-icmp6-nd, since it will be aynschonously closed
by sd_icmp6_nd_unref

5 years agosd-icmp6-nd: fix uninitialized fd
Ronny Chevalier [Thu, 19 Jun 2014 17:32:29 +0000 (19:32 +0200)]
sd-icmp6-nd: fix uninitialized fd

5 years agosd-dhcp6-client: fix uninitialized variables
Ronny Chevalier [Thu, 19 Jun 2014 17:44:03 +0000 (19:44 +0200)]
sd-dhcp6-client: fix uninitialized variables

5 years agocoredump: fix include of xattr.h
Filipe Brandenburger [Thu, 19 Jun 2014 18:18:36 +0000 (11:18 -0700)]
coredump: fix include of xattr.h

The correct path is now <sys/xattr.h> (from glibc-headers) and no longer
<attr/xattr.h> (from libattr-devel.)

Fixes: 34c10968cbe3b5591b3c0ce225b8694edd9709d0

5 years agosd-dhcp6-client: include dhcp6-protocol.h in the list of sources
Filipe Brandenburger [Thu, 19 Jun 2014 18:59:36 +0000 (11:59 -0700)]
sd-dhcp6-client: include dhcp6-protocol.h in the list of sources

If the file is not listed, then "make dist" will not include it.

Tested: "make distcheck" works after this fix is applied.

Fixes: 139b011ab81ccea1d51f09e0261a1c390115c6ff

5 years agosd-dhcp6-client: fix path of sd-icmp6-nd.h in Makefile.am
Filipe Brandenburger [Thu, 19 Jun 2014 18:59:35 +0000 (11:59 -0700)]
sd-dhcp6-client: fix path of sd-icmp6-nd.h in Makefile.am

It was incorrectly looking for a file in src/libsystemd-network/ when the file was actually deployed to src/systemd/ instead.  This broke "make dist".

Tested: "make dist" works again after this patchset is applied.

Fixes: f20a35cc0d537dd4cfc1054cf7936b04a1700f3a

5 years agosd-dhcp6-client: remove bogus dependency on dhcp6-icmp6.h
Filipe Brandenburger [Thu, 19 Jun 2014 18:59:34 +0000 (11:59 -0700)]
sd-dhcp6-client: remove bogus dependency on dhcp6-icmp6.h

Makefile.am had a reference to it but it none of the sources included it.

Tested: "make dist" works again after this patchset is applied.

Fixes: 2ea8857effb833615b16d10fc7a19a7104c19e13

5 years agocopy: don't eat up error from chown()/chmod()
Lennart Poettering [Thu, 19 Jun 2014 22:20:35 +0000 (00:20 +0200)]
copy: don't eat up error from chown()/chmod()

The idea was to not fail on, nor to ignore errors from chown()/chmod(),
but to proceed and simply return the most recent error...

5 years agounits: order systemd-tmpfiles-clean.service after time-sync.target
Lennart Poettering [Thu, 19 Jun 2014 22:15:39 +0000 (00:15 +0200)]
units: order systemd-tmpfiles-clean.service after time-sync.target

That way, on systems lacking an RTC we don't false start removing aged
files too early.