From: Tom Gundersen Date: Wed, 4 Mar 2015 09:33:50 +0000 (+0100) Subject: networkd: netdev - inform when we take over an existing netdev X-Git-Tag: v219.0~505 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=ff88a301e93cf1bddbaa7faa981f390a2a81a4bb;hp=c26c1d86b3e466e073577e27ad839a0c112cd17b networkd: netdev - inform when we take over an existing netdev The crucial point here is that we will not change the settings of a netdev created by someone else we simply use it as is and trust it was set up as intended. This is confusing in the case of the pre-created netdev's (bond0 etc.), the solution should probably be to simply make the kernel stop creating these devices as they are pretty useless. --- diff --git a/src/network/networkd-netdev.c b/src/network/networkd-netdev.c index 3d7cc7345..e98040d6e 100644 --- a/src/network/networkd-netdev.c +++ b/src/network/networkd-netdev.c @@ -260,7 +260,7 @@ static int netdev_create_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userda r = sd_rtnl_message_get_errno(m); if (r == -EEXIST) - log_netdev_debug(netdev, "netdev exists, using existing"); + log_info_netdev(netdev, "netdev exists, using existing without changing its parameters"); else if (r < 0) { log_warning_netdev(netdev, "netdev could not be created: %s", strerror(-r)); netdev_drop(netdev);