From: Andreas Henriksson Date: Fri, 13 Jun 2014 16:48:21 +0000 (+0200) Subject: udev: fix invalid free() in enable_name_policy() X-Git-Tag: v215~439 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=f8a0bb5285024b6ce372c3157e761e6543ebdcd2 udev: fix invalid free() in enable_name_policy() static bool enable_name_policy(...) in ./src/udev/net/link-config.c calls proc_cmdline(...) to get "line" initialized, but proc_cmdline(...) does not guarantee that atleast when both conditions (detect_container(NULL) > 0) and read_full_file(...) returned < 0. --- diff --git a/src/udev/net/link-config.c b/src/udev/net/link-config.c index a9acc3ddb..7a9d01bc1 100644 --- a/src/udev/net/link-config.c +++ b/src/udev/net/link-config.c @@ -185,7 +185,7 @@ static int load_link(link_config_ctx *ctx, const char *filename) { } static bool enable_name_policy(void) { - _cleanup_free_ char *line; + _cleanup_free_ char *line = NULL; char *w, *state; int r; size_t l;