From: Zbigniew Jędrzejewski-Szmek Date: Sat, 12 Oct 2013 17:43:07 +0000 (-0400) Subject: Make sure that we don't dereference NULL X-Git-Tag: v209~1900 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=f6d2d421470a566cca05ceede788d61a0773e276;ds=sidebyside Make sure that we don't dereference NULL The code was actually safe, because b should never be null, because if rvalue is empty, a different branch is taken. But we *do* check for NULL in the loop above, so it's better to also check here for symmetry. --- diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 44920d644..f01843d65 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -1860,7 +1860,8 @@ int config_parse_documentation(const char *unit, free(*a); } } - *b = NULL; + if (b) + *b = NULL; return r; }