From: Mirco Tischler Date: Thu, 5 Mar 2015 00:22:01 +0000 (+0100) Subject: build-sys: fix check for efi-lds file X-Git-Tag: v219.0~496 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=efbef0036d33da7d61deae13477d2f44752ced74 build-sys: fix check for efi-lds file Using the DIR macro breaks caching and has no benefit as it only offers performance improvements when AS_FOR is used with a single element list. Also --with-lds-dir= was broken as we never set have_efi_lds in this case. Fix this and check if PATH actually contains the efi-lds file. --- diff --git a/configure.ac b/configure.ac index 419b5d4e8..14518bc52 100644 --- a/configure.ac +++ b/configure.ac @@ -1182,9 +1182,10 @@ AS_IF([test "x$enable_gnuefi" != "xno"], [ have_efi_lds=no AC_ARG_WITH(efi-ldsdir, AS_HELP_STRING([--with-efi-ldsdir=PATH], [Path to EFI lds directory]), - [EFI_LDS_DIR="$withval"], + [EFI_LDS_DIR="$withval" && AC_CHECK_FILE([${EFI_LDS_DIR}/elf_${EFI_ARCH}_efi.lds], + [have_efi_lds=yes])], [AS_FOR([DIR], [EFI_LDS_DIR], ["${efiroot}/gnuefi" "${efiroot}"], - [AC_CHECK_FILE([DIR/elf_${EFI_ARCH}_efi.lds], + [AC_CHECK_FILE([${EFI_LDS_DIR}/elf_${EFI_ARCH}_efi.lds], [have_efi_lds=yes && break])])]) AS_IF([test "x$have_efi_lds" = xyes], [AC_SUBST([EFI_LDS_DIR])],