From: Kay Sievers <kay@vrfy.org>
Date: Mon, 2 Jul 2012 18:44:05 +0000 (+0200)
Subject: udev: static nodes - fix default permissions if no rules is given
X-Git-Tag: v186~14
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=ef8a2bf6484bb0f82248ceb10a55509a93d82c6b

udev: static nodes - fix default permissions if no rules is given

<falconindy> kay: just curious -- it looks like nodes created by udev from
  modules.devname all have 000 perms, and there's nothing in udev that attempts
  to change this. is it intended?
<falconindy> c---------   1 root root     10, 223 Jul  1 23:10 uinput
<kay> falconindy: we might miss the default of 0600
<falconindy> seems like it
<kay> falconindy: stuff that has a rule works i guess
<kay> falconindy: i'll add the 0600 now
---

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index a5478a754..393e2a920 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -845,10 +845,11 @@ static void static_dev_create_from_modules(struct udev *udev)
                 if (sscanf(devno, "%c%u:%u", &type, &maj, &min) != 3)
                         continue;
 
+                mode  = 0600;
                 if (type == 'c')
-                        mode = S_IFCHR;
+                        mode |= S_IFCHR;
                 else if (type == 'b')
-                        mode = S_IFBLK;
+                        mode |= S_IFBLK;
                 else
                         continue;