From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 13 Jul 2010 00:17:26 +0000 (+0200)
Subject: device: properly create dependencies
X-Git-Tag: v3~16
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=ee5f3479e27286574c34056d4dd16b6d8029e817;ds=sidebyside

device: properly create dependencies
---

diff --git a/src/device.c b/src/device.c
index 2079f1c4e..aeafd5e9f 100644
--- a/src/device.c
+++ b/src/device.c
@@ -252,7 +252,7 @@ static int device_process_new_device(Manager *m, struct udev_device *dev, bool u
                                 goto fail;
                         }
 
-                        r = unit_add_dependency_by_name(u, UNIT_WANTS, NULL, e, true);
+                        r = unit_add_dependency_by_name(u, UNIT_WANTS, e, NULL, true);
                         free(e);
 
                         if (r < 0)
@@ -270,8 +270,12 @@ static int device_process_new_device(Manager *m, struct udev_device *dev, bool u
         return 0;
 
 fail:
+
+        log_warning("Failed to load device unit: %s", strerror(-r));
+
         if (delete && u)
                 unit_free(u);
+
         return r;
 }