From: Václav Pavlín <vpavlin@redhat.com>
Date: Wed, 27 Mar 2013 14:16:35 +0000 (+0100)
Subject: core: check return value of rm_rf_dangerous and warn if it fails
X-Git-Tag: v200~13
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=ebf4fb3d368732d9f41cb40e3084182c04e731b2

core: check return value of rm_rf_dangerous and warn if it fails
---

diff --git a/src/core/execute.c b/src/core/execute.c
index bc876a329..6aa0083bc 100644
--- a/src/core/execute.c
+++ b/src/core/execute.c
@@ -1559,10 +1559,19 @@ void exec_context_tmp_dirs_done(ExecContext *c) {
 
         for(dirp = dirs; *dirp; dirp++) {
                 char *dir;
-                rm_rf_dangerous(*dirp, false, true, false);
+                int r;
 
+                r = rm_rf_dangerous(*dirp, false, true, false);
                 dir = dirname(*dirp);
-                rmdir(dir);
+                if (r < 0)
+                        log_warning("Failed to remove content of temporary directory %s: %s",
+                                    dir, strerror(-r));
+                else {
+                        r = rmdir(dir);
+                        if (r < 0)
+                                log_warning("Failed to remove  temporary directory %s: %s",
+                                            dir, strerror(-r));
+                }
 
                 free(*dirp);
         }