From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mon, 13 Jun 2016 00:57:41 +0000 (-0400)
Subject: process-util: remove broken support for pid==0
X-Git-Tag: v231.3~102
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=cf527c6873b86266ab75e56f28e2eada23866296;hp=6bc15ba0015c5c35d2d3e68d0ed193e6c5e5f81d

process-util: remove broken support for pid==0

Our functions that query /proc/pid/ support using pid==0 to mean
self. get_process_id also seemed to support that, but it was not implemented
correctly: the result should be in *uid, not returned, and also it gave
completely bogus result when called from get_process_gid(). But afaict,
get_process_{uid,gid} were never called with pid==0, so it's not an actual
bug. Remove the broken code to avoid confusion.
---

diff --git a/src/basic/process-util.c b/src/basic/process-util.c
index f418b85b9..faadb756c 100644
--- a/src/basic/process-util.c
+++ b/src/basic/process-util.c
@@ -321,9 +321,6 @@ static int get_process_id(pid_t pid, const char *field, uid_t *uid) {
         assert(field);
         assert(uid);
 
-        if (pid == 0)
-                return getuid();
-
         p = procfs_file_alloca(pid, "status");
         f = fopen(p, "re");
         if (!f) {