From: Philippe De Swert <philippe.deswert@jollamobile.com>
Date: Sun, 28 Sep 2014 15:12:51 +0000 (+0300)
Subject: bootchart: Do not try to access data for non-existing CPU's
X-Git-Tag: v217~413
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=c119700c06b248b1c2a082b40b1a346f58d89da0

bootchart: Do not try to access data for non-existing CPU's

Cpu's are assigned normally, so starting at 0, so the MAX_CPU index will
always be one smaller than the actual number.

Found with Coverity.
---

diff --git a/src/bootchart/store.c b/src/bootchart/store.c
index 3099ff120..9ea1b27de 100644
--- a/src/bootchart/store.c
+++ b/src/bootchart/store.c
@@ -199,7 +199,7 @@ vmstat_next:
 
                 if (strstr(key, "cpu")) {
                         r = safe_atoi((const char*)(key+3), &c);
-                        if (r < 0 || c > MAXCPUS)
+                        if (r < 0 || c > MAXCPUS -1)
                                 /* Oops, we only have room for MAXCPUS data */
                                 break;
                         sampledata->runtime[c] = atoll(rt);