From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Fri, 27 Dec 2013 20:57:12 +0000 (+0100)
Subject: autogen: add shortcut for running scan-build
X-Git-Tag: v209~600
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=a8c78decf0533f6ada9748ba073f861183cda837;ds=inline

autogen: add shortcut for running scan-build

scan-build is a static analyzer in llvm. As ususal static analyzers
tend to mostly find theoretical bugs in software that has been in
production for a while. For in-development code it can be useful to
check if new issues is added as there is a chance to spot real problems
before release. For systemd we are now down to 297 issues - the vast
majority are false positives because the tool does not understand the
cleanup attribute.

Running clang's static analyzer scan-build is a bit messy. You have to
run both configure and make "inside" the build-scan tool. To have an
easy shortcut from autogen.sh I thus call both directly from it. This
makes it different from the other options in autogen.sh. I chose 's'
for static analysis.

scan-build is in the package clang-analyzer on fedora.
---

diff --git a/autogen.sh b/autogen.sh
index 91df10a26..49d551975 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -65,6 +65,9 @@ elif [ "x$1" = "xa" ]; then
 elif [ "x$1" = "xl" ]; then
         ./configure CC=clang CFLAGS='-g -O0 -ftrapv -Wno-cast-align -Wno-gnu' --enable-kdbus $args
         make clean
+elif [ "x$1" = "xs" ]; then
+        scan-build ./configure CFLAGS='-g -O0 -ftrapv' --enable-kdbus $args
+        scan-build make
 else
         echo
         echo "----------------------------------------------------------------"