From: Dave Reisner <dreisner@archlinux.org>
Date: Fri, 4 Oct 2013 22:22:40 +0000 (-0400)
Subject: mount: check for NULL before reading pm->what
X-Git-Tag: v209~1973
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=9c03872bc8fb2a381eafe7301ef9811b641686dd

mount: check for NULL before reading pm->what

Since a57f7e2c828b85, a mount unit with garbage in it would cause
systemd to crash on loading it.

ref: https://bugs.freedesktop.org/show_bug.cgi?id=70148
---

diff --git a/src/core/mount.c b/src/core/mount.c
index 93bfa99f3..db055f0a0 100644
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -182,7 +182,7 @@ static int mount_add_mount_links(Mount *m) {
          * for the source path (if this is a bind mount) to be
          * available. */
         pm = get_mount_parameters_fragment(m);
-        if (pm && path_is_absolute(pm->what)) {
+        if (pm && pm->what && path_is_absolute(pm->what)) {
                 r = unit_require_mounts_for(UNIT(m), pm->what);
                 if (r < 0)
                         return r;