From: Michal Schmidt <mschmidt@redhat.com>
Date: Fri, 28 Nov 2014 18:20:59 +0000 (+0100)
Subject: core: fix return value in error path after sd_event_add_io() failure
X-Git-Tag: v218~242
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=895b3a7b44fe7ca2f260986be2a877ff56a72718

core: fix return value in error path after sd_event_add_io() failure

sd_event_add_io() does not set errno, it returns negative errno.

Noticed during log_*_errno conversions.
---

diff --git a/src/core/manager.c b/src/core/manager.c
index 7b6172896..a84272c90 100644
--- a/src/core/manager.c
+++ b/src/core/manager.c
@@ -692,10 +692,8 @@ static int manager_setup_notify(Manager *m) {
 
         if (!m->notify_event_source) {
                 r = sd_event_add_io(m->event, &m->notify_event_source, m->notify_fd, EPOLLIN, manager_dispatch_notify_fd, m);
-                if (r < 0) {
-                        log_error_errno(r, "Failed to allocate notify event source: %m");
-                        return -errno;
-                }
+                if (r < 0)
+                        return log_error_errno(r, "Failed to allocate notify event source: %m");
 
                 /* Process signals a bit earlier than SIGCHLD, so that we can
                  * still identify to which service an exit message belongs */