From: Umut Tezduyar Lindskog Date: Wed, 8 Jul 2015 12:35:32 +0000 (+0200) Subject: property callback returns are consistent X-Git-Tag: v226.4~1^2~221 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=8286423f0eaf8b4cd8229612bdcbeef381cf1a09 property callback returns are consistent It is no different to return 0 over 1 in the property callback. It is confusing to return 1 which made me think 1 has a special purpose. This way code is consistent with the rest of the tree. --- diff --git a/src/login/logind-user-dbus.c b/src/login/logind-user-dbus.c index 0f72d70b1..36c0e8626 100644 --- a/src/login/logind-user-dbus.c +++ b/src/login/logind-user-dbus.c @@ -103,11 +103,7 @@ static int property_get_sessions( } - r = sd_bus_message_close_container(reply); - if (r < 0) - return r; - - return 1; + return sd_bus_message_close_container(reply); } static int property_get_idle_hint(