From: kay.sievers@vrfy.org <kay.sievers@vrfy.org>
Date: Fri, 19 Nov 2004 02:49:13 +0000 (+0100)
Subject: [PATCH] prevent udevd crash if DEVPATH is not set
X-Git-Tag: 046~3
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=80513ea38f66855fe9232d6eab3ab9469c379cad;ds=sidebyside

[PATCH] prevent udevd crash if DEVPATH is not set

Just move the event straight to the exec list and don't try
to compare a NULL pointer.
---

diff --git a/udevd.c b/udevd.c
index 43f3f0324..dd505d03d 100644
--- a/udevd.c
+++ b/udevd.c
@@ -153,9 +153,14 @@ static void udev_run(struct hotplug_msg *msg)
 static struct hotplug_msg *running_with_devpath(struct hotplug_msg *msg)
 {
 	struct hotplug_msg *loop_msg;
-	list_for_each_entry(loop_msg, &running_list, list)
-		if (strncmp(loop_msg->devpath, msg->devpath, sizeof(loop_msg->devpath)) == 0)
+	list_for_each_entry(loop_msg, &running_list, list) {
+		if (loop_msg->devpath == NULL || msg->devpath == NULL)
+			continue;
+
+		if (strcmp(loop_msg->devpath, msg->devpath) == 0)
 			return loop_msg;
+	}
+
 	return NULL;
 }