From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 20 Nov 2014 19:59:57 +0000 (+0100)
Subject: busctl: use canned error message on parse failure
X-Git-Tag: v218~407
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=79f34de9fb8e4faa6ed0847b386099a4ba100a8a;ds=inline

busctl: use canned error message on parse failure
---

diff --git a/src/libsystemd/sd-bus/busctl.c b/src/libsystemd/sd-bus/busctl.c
index 33be4e8b6..4da807437 100644
--- a/src/libsystemd/sd-bus/busctl.c
+++ b/src/libsystemd/sd-bus/busctl.c
@@ -35,6 +35,7 @@
 #include "bus-util.h"
 #include "bus-dump.h"
 #include "bus-signature.h"
+#include "bus-type.h"
 #include "busctl-introspect.h"
 
 static bool arg_no_pager = false;
@@ -1213,10 +1214,8 @@ static int call(sd_bus *bus, char *argv[]) {
         }
 
         r = sd_bus_message_new_method_call(bus, &m, argv[1], argv[2], argv[3], argv[4]);
-        if (r < 0) {
-                log_error("Failed to prepare bus message: %s", strerror(-r));
-                return r;
-        }
+        if (r < 0)
+                return bus_log_create_error(r);
 
         if (!isempty(argv[5])) {
                 char **p;