From: Kay Sievers Date: Sat, 5 Jun 2010 08:30:36 +0000 (+0200) Subject: libudev: fix fd leak in udev_enumerate_scan_devices() when tags are searched X-Git-Tag: 174~446 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=727b12d6500f6e08c4ae2ad2ce75281f03d0ffcb;hp=94aa758d0c4c3d01d70e2480db63224250a47d89 libudev: fix fd leak in udev_enumerate_scan_devices() when tags are searched Thanks to Lennart for finding this. --- diff --git a/Makefile.am b/Makefile.am index caca2555f..bafe4c7fa 100644 --- a/Makefile.am +++ b/Makefile.am @@ -29,7 +29,7 @@ CLEANFILES = # libudev # ------------------------------------------------------------------------------ LIBUDEV_CURRENT=8 -LIBUDEV_REVISION=2 +LIBUDEV_REVISION=3 LIBUDEV_AGE=8 SUBDIRS += libudev/docs diff --git a/libudev/libudev-enumerate.c b/libudev/libudev-enumerate.c index da831449d..f13e56f2f 100644 --- a/libudev/libudev-enumerate.c +++ b/libudev/libudev-enumerate.c @@ -735,6 +735,7 @@ int udev_enumerate_scan_devices(struct udev_enumerate *udev_enumerate) syspath_add(udev_enumerate, udev_device_get_syspath(dev)); udev_device_unref(dev); } + closedir(dir); } } else { util_strscpyl(base, sizeof(base), udev_get_sys_path(udev), "/subsystem", NULL);