From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 26 Apr 2011 19:39:14 +0000 (+0200)
Subject: socket: improve warning message when we get POLLHUP
X-Git-Tag: v26~19
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=641e01dcdcc810026ee4156d1694d97e10a1ba07

socket: improve warning message when we get POLLHUP
---

diff --git a/src/socket.c b/src/socket.c
index ad67215c1..0a18716cd 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -1679,7 +1679,12 @@ static void socket_fd_event(Unit *u, int fd, uint32_t events, Watch *w) {
         log_debug("Incoming traffic on %s", u->meta.id);
 
         if (events != EPOLLIN) {
-                log_error("%s: Got invalid poll event (0x%x) on socket.", u->meta.id, events);
+
+                if (events & EPOLLHUP)
+                        log_error("%s: Got POLLHUP on a listening socket. The service probably invoked shutdown() on it, and should better not do that.", u->meta.id);
+                else
+                        log_error("%s: Got unexpected poll event (0x%x) on socket.", u->meta.id, events);
+
                 goto fail;
         }