From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Sun, 28 Sep 2014 16:46:15 +0000 (+0200)
Subject: test-bus-policy: silence coverity
X-Git-Tag: v217~414
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=5e90b6a978d15efedc5b5cc4a3d2d922a0ecd2a9;hp=e931d3f4241231e4102eda06adaf7cbfd68c6a5d

test-bus-policy: silence coverity

Check if strjoin worked and also use _cleanup_free_ since we are
here.

Found with Coverity. Fixes CID#1241962
---

diff --git a/src/bus-proxyd/test-bus-policy.c b/src/bus-proxyd/test-bus-policy.c
index 900e4d2b0..7bcebef90 100644
--- a/src/bus-proxyd/test-bus-policy.c
+++ b/src/bus-proxyd/test-bus-policy.c
@@ -46,18 +46,17 @@
 
 static int test_policy_load(Policy *p, const char *name)
 {
-        char *path;
+        _cleanup_free_ char *path = NULL;
         int r = 0;
 
         path = strjoin(TEST_DIR, "/bus-policy/", name, NULL);
+        assert_se(path);
 
         if (access(path, R_OK) == 0)
                 policy_load(p, STRV_MAKE(path));
         else
                 r = -ENOENT;
 
-        free(path);
-
         return r;
 }