From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 26 Jun 2013 23:48:32 +0000 (-0400)
Subject: killall: do not use alloca() in argument list
X-Git-Tag: v205~70
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=5841bd803f1b651c0d70c6ae114630723a76d1da

killall: do not use alloca() in argument list

It is not allowed.
---

diff --git a/src/core/killall.c b/src/core/killall.c
index a0f57455f..e39505010 100644
--- a/src/core/killall.c
+++ b/src/core/killall.c
@@ -33,7 +33,7 @@
 
 static bool ignore_proc(pid_t pid) {
         _cleanup_fclose_ FILE *f = NULL;
-        char c;
+        char c, *p;
         size_t count;
         uid_t uid;
         int r;
@@ -50,7 +50,8 @@ static bool ignore_proc(pid_t pid) {
         if (uid != 0)
                 return false;
 
-        f = fopen(procfs_file_alloca(pid, "cmdline"), "re");
+        p = procfs_file_alloca(pid, "cmdline");
+        f = fopen(p, "re");
         if (!f)
                 return true; /* not really, but has the desired effect */