From: Zbigniew Jędrzejewski-Szmek Date: Thu, 6 Feb 2014 05:31:22 +0000 (-0500) Subject: bash-completion: fix completion of complete verbs X-Git-Tag: v209~240 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=3ce09b7da2eb8b888066468663b2b5c81a05a03c bash-completion: fix completion of complete verbs When doing 'command verb', the arguments for verb would be proposed, but it is too early. We should complete verb first. https://bugs.freedesktop.org/show_bug.cgi?id=74596 --- diff --git a/shell-completion/bash/busctl b/shell-completion/bash/busctl index 8ce813f4b..7480a6c3f 100644 --- a/shell-completion/bash/busctl +++ b/shell-completion/bash/busctl @@ -53,7 +53,7 @@ _busctl() { [STANDALONE]='list monitor' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]} && ! __contains_word "${COMP_WORDS[i-1]}" ${OPTS[ARG]}; then verb=${COMP_WORDS[i]} diff --git a/shell-completion/bash/hostnamectl b/shell-completion/bash/hostnamectl index 38ab1344f..9c75da9e7 100644 --- a/shell-completion/bash/hostnamectl +++ b/shell-completion/bash/hostnamectl @@ -41,7 +41,7 @@ _hostnamectl() { [NAME]='set-hostname' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]}; then verb=${COMP_WORDS[i]} break diff --git a/shell-completion/bash/localectl b/shell-completion/bash/localectl index bec9e78c6..84e2a6b09 100644 --- a/shell-completion/bash/localectl +++ b/shell-completion/bash/localectl @@ -52,7 +52,7 @@ _localectl() { [X11]='set-x11-keymap' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]}; then verb=${COMP_WORDS[i]} break diff --git a/shell-completion/bash/loginctl b/shell-completion/bash/loginctl index 7263f7f7b..e7adb93f9 100644 --- a/shell-completion/bash/loginctl +++ b/shell-completion/bash/loginctl @@ -70,7 +70,7 @@ _loginctl () { [ATTACH]='attach' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]} && ! __contains_word "${COMP_WORDS[i-1]}" ${OPTS[ARG]}; then verb=${COMP_WORDS[i]} diff --git a/shell-completion/bash/systemctl b/shell-completion/bash/systemctl index 232d2d65f..dc7ef6689 100644 --- a/shell-completion/bash/systemctl +++ b/shell-completion/bash/systemctl @@ -146,7 +146,7 @@ _systemctl () { [TARGETS]='set-default' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]} && ! __contains_word "${COMP_WORDS[i-1]}" ${OPTS[ARG]}; then verb=${COMP_WORDS[i]} diff --git a/shell-completion/bash/systemd-analyze b/shell-completion/bash/systemd-analyze index 98c793be9..6afcd963c 100644 --- a/shell-completion/bash/systemd-analyze +++ b/shell-completion/bash/systemd-analyze @@ -39,7 +39,7 @@ _systemd_analyze() { _init_completion || return - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]} && ! __contains_word "${COMP_WORDS[i-1]}" ${OPTS[ARG]}; then verb=${COMP_WORDS[i]} diff --git a/shell-completion/bash/timedatectl b/shell-completion/bash/timedatectl index c6a654525..1a0acc6c7 100644 --- a/shell-completion/bash/timedatectl +++ b/shell-completion/bash/timedatectl @@ -52,7 +52,7 @@ _timedatectl() { [TIME]='set-time' ) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" ${VERBS[*]}; then verb=${COMP_WORDS[i]} break diff --git a/shell-completion/bash/udevadm b/shell-completion/bash/udevadm index d58cdf532..b828b8dd7 100644 --- a/shell-completion/bash/udevadm +++ b/shell-completion/bash/udevadm @@ -36,7 +36,7 @@ _udevadm() { local verbs=(info trigger settle control monitor hwdb test-builtin test) - for ((i=0; i <= COMP_CWORD; i++)); do + for ((i=0; i < COMP_CWORD; i++)); do if __contains_word "${COMP_WORDS[i]}" "${verbs[@]}" && ! __contains_word "${COMP_WORDS[i-1]}" ${OPTS[ARG]}; then verb=${COMP_WORDS[i]}