From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Wed, 25 Feb 2015 22:10:35 +0000 (+0100)
Subject: bootctl: check that partition uuid is valid
X-Git-Tag: v219.0~568
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=3a4efbff2e729194d286f483bd8e122c52ff1129;hp=5bd4b173605142c7be493aa4d958ebaef21f421d

bootctl: check that partition uuid is valid

It probably is but check anyway to make coverity happy.

CID#1271354
---

diff --git a/src/boot/bootctl.c b/src/boot/bootctl.c
index fb568bebb..bd55fa95b 100644
--- a/src/boot/bootctl.c
+++ b/src/boot/bootctl.c
@@ -177,7 +177,13 @@ static int verify_esp(const char *p, uint32_t *part, uint64_t *pstart, uint64_t
                 fprintf(stderr, "Failed to probe partition entry UUID %s: %s\n", p, strerror(-r));
                 goto fail;
         }
-        sd_id128_from_string(v, uuid);
+
+        r = sd_id128_from_string(v, uuid);
+        if (r < 0) {
+                fprintf(stderr, "Partition %s has invalid UUID: %s\n", p, v);
+                r = -EIO;
+                goto fail;
+        }
 
         errno = 0;
         r = blkid_probe_lookup_value(b, "PART_ENTRY_NUMBER", &v, NULL);