From: Patrik Flykt <patrik.flykt@linux.intel.com>
Date: Fri, 20 Dec 2013 15:16:16 +0000 (+0200)
Subject: libsystemd-dhcp: Check test result without casting value
X-Git-Tag: v209~726
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=2fba7b03b515b842f5a33d9e1ec46bfa7767d393

libsystemd-dhcp: Check test result without casting value
---

diff --git a/src/libsystemd-dhcp/test-dhcp-client.c b/src/libsystemd-dhcp/test-dhcp-client.c
index 7400cc683..1ff78c114 100644
--- a/src/libsystemd-dhcp/test-dhcp-client.c
+++ b/src/libsystemd-dhcp/test-dhcp-client.c
@@ -119,13 +119,7 @@ static void test_checksum(void)
                 0xff, 0xff, 0xff, 0xff
         };
 
-        uint8_t check[2] = {
-                0x78, 0xae
-        };
-
-        uint16_t *val = (uint16_t *)check;
-
-        assert(client_checksum(&buf, 20) == *val);
+        assert(client_checksum(&buf, 20) == be16toh(0x78ae));
 }
 
 static int check_options(uint8_t code, uint8_t len, const uint8_t *option,