From: Tom Gundersen <teg@jklm.no>
Date: Tue, 19 Aug 2014 13:41:23 +0000 (+0200)
Subject: networkd: fix use-after-free
X-Git-Tag: v216~34
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=2c36be2f4ba38f9097cdcdcd1e724ffa46da12c7

networkd: fix use-after-free

Elements must be removed from the hashtable before they are freed.
---

diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c
index 803fcdd60..fc6239521 100644
--- a/src/network/networkd-network.c
+++ b/src/network/networkd-network.c
@@ -172,8 +172,10 @@ void network_free(Network *network) {
 
         netdev_unref(network->bond);
 
-        HASHMAP_FOREACH(netdev, network->stacked_netdevs, i)
+        HASHMAP_FOREACH(netdev, network->stacked_netdevs, i) {
+                hashmap_remove(network->stacked_netdevs, netdev->ifname);
                 netdev_unref(netdev);
+        }
         hashmap_free(network->stacked_netdevs);
 
         while ((route = network->static_routes))