From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 27 Oct 2014 22:50:51 +0000 (+0100)
Subject: journald: be nice to coverity, add an extra assert
X-Git-Tag: v217~44
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=294330896d1ad26c10eecf6c3bf20d73b5ec624b

journald: be nice to coverity, add an extra assert

coverity otherwise assumes that the chain object might be NULL.
---

diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
index d06dbc2f7..8a2c0fcac 100644
--- a/src/journal/journal-file.c
+++ b/src/journal/journal-file.c
@@ -1380,9 +1380,10 @@ static void chain_cache_put(
                 if (array == first)
                         return;
 
-                if (ordered_hashmap_size(h) >= CHAIN_CACHE_MAX)
+                if (ordered_hashmap_size(h) >= CHAIN_CACHE_MAX) {
                         ci = ordered_hashmap_steal_first(h);
-                else {
+                        assert(ci);
+                } else {
                         ci = new(ChainCacheItem, 1);
                         if (!ci)
                                 return;