From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 21 Feb 2017 16:15:19 +0000 (-0500)
Subject: basic/fileio: fix memleak when discarding an invalid variable
X-Git-Tag: v233.3~45
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=1d2be1ab6a2d4eab94cfd4421753114184923195;ds=sidebyside

basic/fileio: fix memleak when discarding an invalid variable

Fixes #5405.
---

diff --git a/src/basic/fileio.c b/src/basic/fileio.c
index eadc8b7ea..5cf33b48b 100644
--- a/src/basic/fileio.c
+++ b/src/basic/fileio.c
@@ -780,6 +780,7 @@ static int merge_env_file_push(
 
         if (!env_name_is_valid(key)) {
                 log_error("%s:%u: invalid variable name \"%s\", ignoring.", strna(filename), line, key);
+                free(value);
                 return 0;
         }