From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 3 Dec 2013 17:58:18 +0000 (+0100)
Subject: core: use normal library call to query list of current names
X-Git-Tag: v209~1133
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=0e7be1293fe70eed47b20f70f74a2a67fc87be17;hp=71f2ab468d8413cffdb712083eb4d06dc8b2a271

core: use normal library call to query list of current names
---

diff --git a/TODO b/TODO
index 39c38dd7e..eb3805ec4 100644
--- a/TODO
+++ b/TODO
@@ -130,7 +130,7 @@ Features:
   - longer term:
     * priority queues
     * priority inheritance
-  - sort out error codes for sd_bus_release_name()
+  - sort out error codes for sd_bus_release_name(), distuingish: successful removal from foreign name, from non-existing name
 
 * sd-event
   - allow multiple signal handlers per signal
diff --git a/src/core/dbus.c b/src/core/dbus.c
index cda1c5d5b..cab7628ad 100644
--- a/src/core/dbus.c
+++ b/src/core/dbus.c
@@ -742,42 +742,24 @@ static int bus_on_connection(sd_event_source *s, int fd, uint32_t revents, void
 }
 
 static int bus_list_names(Manager *m, sd_bus *bus) {
-        _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
-        _cleanup_bus_message_unref_ sd_bus_message *reply = NULL;
-        const char *name;
+        _cleanup_strv_free_ char **names = NULL;
+        char **i;
         int r;
 
         assert(m);
         assert(bus);
 
-        r = sd_bus_call_method(
-                        bus,
-                        "org.freedesktop.DBus",
-                        "/org/freedesktop/DBus",
-                        "org.freedesktop.DBus",
-                        "ListNames",
-                        &error, &reply,
-                        NULL);
+        r = sd_bus_list_names(bus, &names, NULL);
         if (r < 0) {
-                log_error("Failed to get initial list of names: %s", bus_error_message(&error, r));
+                log_error("Failed to get initial list of names: %s", strerror(-r));
                 return r;
         }
 
-        r = sd_bus_message_enter_container(reply, 'a', "s");
-        if (r < 0)
-                return bus_log_parse_error(r);
-
         /* This is a bit hacky, we say the owner of the name is the
          * name itself, because we don't want the extra traffic to
          * figure out the real owner. */
-        while ((r = sd_bus_message_read(reply, "s", &name)) > 0)
-                manager_dispatch_bus_name_owner_changed(m, name, NULL, name);
-        if (r < 0)
-                return bus_log_parse_error(r);
-
-        r = sd_bus_message_exit_container(reply);
-        if (r < 0)
-                return bus_log_parse_error(r);
+        STRV_FOREACH(i, names)
+                manager_dispatch_bus_name_owner_changed(m, *i, NULL, *i);
 
         return 0;
 }